From: Josef Bacik <jbacik@fusionio.com>
To: Sage Weil <sage@inktank.com>
Cc: Josef Bacik <JBacik@fusionio.com>,
"linux-btrfs@vger.kernel.org" <linux-btrfs@vger.kernel.org>
Subject: Re: [PATCH] Btrfs: pass lockdep rwsem metadata to async commit transaction
Date: Mon, 27 Aug 2012 18:29:22 -0400 [thread overview]
Message-ID: <20120827222922.GA3310@localhost.localdomain> (raw)
In-Reply-To: <alpine.DEB.2.00.1208271446580.26910@cobra.newdream.net>
On Mon, Aug 27, 2012 at 04:05:37PM -0600, Sage Weil wrote:
> On Sun, 26 Aug 2012, Josef Bacik wrote:
> > On Fri, Aug 24, 2012 at 04:47:56PM -0600, Sage Weil wrote:
> > > Sadly, now I hit another one:
> > >
> >
> > Oh haha you need to set current->journal_info to the trans you have before you
> > call commit_transaction in do_async_commit. Thanks,
>
> Ah, makes sense. But now...
>
Um so I don't think we need to be holding cleanup_work_sem() in
run_delayed_iputs(), it's meant to protect the running of the orphan cleanup.
So just remove it in btrfs_run_delayed_iputs() and see how that goes? Thanks,
Josef
prev parent reply other threads:[~2012-08-27 22:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-24 22:44 [PATCH] Btrfs: pass lockdep rwsem metadata to async commit transaction Sage Weil
2012-08-24 22:47 ` Sage Weil
2012-08-26 21:13 ` Josef Bacik
2012-08-27 22:05 ` Sage Weil
2012-08-27 22:29 ` Josef Bacik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120827222922.GA3310@localhost.localdomain \
--to=jbacik@fusionio.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=sage@inktank.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).