From: Roman Mamedov <rm@romanrm.ru>
To: Goffredo Baroncelli <kreijack@gmail.com>
Cc: "Chris Mason" <chris.mason@fusionio.com>,
"linux-btrfs@vger.kernel.org" <linux-btrfs@vger.kernel.org>,
"Hugo Mills" <hugo@carfax.org.uk>,
"Sébastien Maury" <sebastien.maury@inserm.fr>,
"Goffredo Baroncelli" <kreijack@inwind.it>
Subject: Re: [PATCH][BTRFS-PROGS] btrfs filesystem disk-usage
Date: Wed, 3 Oct 2012 12:34:46 +0600 [thread overview]
Message-ID: <20121003123446.4e4db403@natsu> (raw)
In-Reply-To: <CAJHuE_BmvmEteSg8YgcHH3cuB27Bi-j-B=yS7Y2NFhb1L5_Aog@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1271 bytes --]
On Wed, 3 Oct 2012 08:22:06 +0200
Goffredo Baroncelli <kreijack@gmail.com> wrote:
> On Wed, Oct 3, 2012 at 1:46 AM, Chris Mason <chris.mason@fusionio.com> wrote:
> [...]
> > I like it, thanks. Could you please update btrfs fi df to show this
> > instead of adding a new command though?
>
> Hi Chris,
> no problem to update the patches, however I have one suggestion:
> - leave "btrfs fi df" as is to no break any script (if any) which
> would uses it. Hide it from the help and deprecating it in the man
> page. This because the output is very different.
> - renaming "btrfs fi disk-usage" in "btrfs fi disk-free", which make sense.
1) btrfs is still labeled experimental, so no script author should have
seriously relied on utilities text output to stay unchanged long-term;
personally I don't see modifying it (especially not in some superficial way,
but as a part of major improvement) to be a problem;
2) "disk-usage" and "disk-free" are both way too awkward and too long to type,
compared to "fi df", and "df" is the expected shorthand for "disk free" in the
UNIX land.
--
With respect,
Roman
~~~~~~~~~~~~~~~~~~~~~~~~~~~
"Stallman had a printer,
with code he could not see.
So he began to tinker,
and set the software free."
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
next prev parent reply other threads:[~2012-10-03 6:34 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-02 18:36 [PATCH][BTRFS-PROGS] btrfs filesystem disk-usage Goffredo Baroncelli
2012-10-02 18:36 ` [PATCH 1/2] Add btrfs filesystem disk-usage command Goffredo Baroncelli
2012-10-02 18:36 ` [PATCH 2/2] Update help page Goffredo Baroncelli
2012-10-02 23:46 ` [PATCH][BTRFS-PROGS] btrfs filesystem disk-usage Chris Mason
2012-10-03 6:22 ` Goffredo Baroncelli
2012-10-03 6:34 ` Roman Mamedov [this message]
2012-10-03 6:40 ` Sébastien Maury
2012-10-03 9:14 ` Martin Steigerwald
2012-10-03 11:22 ` Chris Mason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121003123446.4e4db403@natsu \
--to=rm@romanrm.ru \
--cc=chris.mason@fusionio.com \
--cc=hugo@carfax.org.uk \
--cc=kreijack@gmail.com \
--cc=kreijack@inwind.it \
--cc=linux-btrfs@vger.kernel.org \
--cc=sebastien.maury@inserm.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).