From: Josef Bacik <jbacik@fusionio.com>
To: Alex Lyakas <alex.bolshoy.btrfs@gmail.com>
Cc: Josef Bacik <JBacik@fusionio.com>,
"linux-btrfs@vger.kernel.org" <linux-btrfs@vger.kernel.org>,
Jan Schmidt <list.btrfs@jan-o-sch.net>
Subject: Re: [PATCH] Btrfs: try to avoid doing a search in btrfs_next_leaf
Date: Wed, 3 Oct 2012 09:32:42 -0400 [thread overview]
Message-ID: <20121003133242.GM2370@localhost.localdomain> (raw)
In-Reply-To: <CAHf9xvbKMLjrn2MOo4O+NZhHHOFUaXsJ+KwkqBkbUvKKbD9jYg@mail.gmail.com>
On Wed, Oct 03, 2012 at 06:57:26AM -0600, Alex Lyakas wrote:
> Hi Josef,
> in send code, in full_send_tree() there is code like this:
> key.objectid = found_key.objectid;
> key.type = found_key.type;
> key.offset = found_key.offset + 1;
>
> ret = btrfs_next_item(send_root, path);
> if (ret < 0)
> goto out;
> if (ret) {
> ret = 0;
> break;
>
> It wants to jump to the next greater key in the tree, whatever
> objectid it has (the reason is that here we need to traverse the whole
> file tree). I believe with your change it might get broken... What do
> you think?
Yeah you are right, I'll hold off on this for now. Thanks,
Josef
prev parent reply other threads:[~2012-10-03 13:32 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-24 20:02 [PATCH] Btrfs: try to avoid doing a search in btrfs_next_leaf Josef Bacik
2012-09-30 11:28 ` Alex Lyakas
2012-10-01 16:45 ` Josef Bacik
2012-10-02 8:17 ` Alex Lyakas
2012-10-02 14:25 ` David Sterba
2012-10-02 14:32 ` Josef Bacik
2012-10-02 15:05 ` David Sterba
2012-10-02 15:27 ` Josef Bacik
2012-10-02 15:30 ` Arne Jansen
2012-10-03 12:57 ` Alex Lyakas
2012-10-03 13:32 ` Josef Bacik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121003133242.GM2370@localhost.localdomain \
--to=jbacik@fusionio.com \
--cc=alex.bolshoy.btrfs@gmail.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=list.btrfs@jan-o-sch.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).