linux-btrfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Mark Fasheh <mfasheh@suse.de>
To: Jan Schmidt <list.btrfs@jan-o-sch.net>
Cc: Chris Mason <chris.mason@fusionio.com>, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH v4 3/4] btrfs: extended inode refs
Date: Tue, 9 Oct 2012 11:25:03 -0700	[thread overview]
Message-ID: <20121009182503.GW8097@wotan.suse.de> (raw)
In-Reply-To: <50741E0D.30505@jan-o-sch.net>

On Tue, Oct 09, 2012 at 02:52:29PM +0200, Jan Schmidt wrote:
> Hi Chris, Hi Mark,
> 
> I'm currently working on extended inode refs for btrfs send, reading the version
> of fs/btrfs/backref.c in Chris' next branch. Concerning commit
> f8728be56e48e4a64ed49a71c66b3e6436869838 ...
> 
> On Mon, August 20, 2012 at 22:29 (+0200), Mark Fasheh wrote:
> > Teach tree-log.c about extended inode refs. In particular, we have to adjust
> > the behavior of inode ref replay as well as log tree recovery to account for
> > the existence of extended refs.
> > 
> > Signed-off-by: Mark Fasheh <mfasheh@suse.de>
> > ---
> >  fs/btrfs/backref.c  |   68 +++++++++++
> >  fs/btrfs/backref.h  |    5 +
> >  fs/btrfs/tree-log.c |  316 ++++++++++++++++++++++++++++++++++++++++++---------
> >  3 files changed, 337 insertions(+), 52 deletions(-)
> 
> I had made comments on v3 of this one, which were obviously ignored for v4. I
> did not reply to v4, which is the version in "next". Despite that, this commit
> has got a
> 
>     Reviewed-by: Jan Schmidt <list.btrfs@jan-o-sch.net
> 
> Chris, can you please remove that tag from the commit mentioned?

Yes, this was clearly a mistake - pretty much neither of us could completely
figure out that code ;)

I think what happened is the Reviewed-by: from what *used* to be patch 3 got
accidentally applied to this one:

http://marc.info/?l=linux-btrfs&m=134502070513822&w=4

They are very obviously different patches though.
	--Mark

--
Mark Fasheh

  reply	other threads:[~2012-10-09 18:25 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-20 20:29 [PATCH v4 0/4] btrfs: extended inode refs Mark Fasheh
2012-08-20 20:29 ` [PATCH v4 1/4] " Mark Fasheh
2012-08-23 10:27   ` Jan Schmidt
2012-08-20 20:29 ` [PATCH v4 2/4] btrfs: improved readablity for add_inode_ref Mark Fasheh
2012-08-20 20:29 ` [PATCH v4 3/4] btrfs: extended inode refs Mark Fasheh
2012-10-09 12:52   ` Jan Schmidt
2012-10-09 18:25     ` Mark Fasheh [this message]
2012-08-20 20:29 ` [PATCH v4 4/4] " Mark Fasheh
2012-09-25 20:04 ` [PATCH v4 0/4] " Chris Mason
2012-09-27  8:25   ` David Sterba
2012-09-27 19:49   ` Mark Fasheh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20121009182503.GW8097@wotan.suse.de \
    --to=mfasheh@suse.de \
    --cc=chris.mason@fusionio.com \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=list.btrfs@jan-o-sch.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).