From: Arnd Bergmann <arnd@arndb.de>
To: "Markus F.X.J. Oberhumer" <markus@oberhumer.com>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org, Andi Kleen <andi@firstfloor.org>,
Johannes Stezenbach <js@sig21.net>,
"richard -rw- weinberger" <richard.weinberger@gmail.com>,
linux-btrfs@vger.kernel.org, linux-crypto@vger.kernel.org,
Artem Bityutskiy <dedekind1@gmail.com>,
Adrian Hunter <adrian.hunter@intel.com>,
David Woodhouse <dwmw2@infradead.org>,
Phillip Lougher <phillip@squashfs.org.uk>,
Dan Magenheimer <dan.magenheimer@oracle.com>,
Dan Carpenter <dan.carpenter@oracle.com>
Subject: Re: [PATCH 0/3] Update LZO compression
Date: Thu, 11 Oct 2012 11:41:27 +0000 [thread overview]
Message-ID: <201210111141.27270.arnd@arndb.de> (raw)
In-Reply-To: <50748113.80408@oberhumer.com>
On Tuesday 09 October 2012, Markus F.X.J. Oberhumer wrote:
> >
> > : This commit updates the kernel LZO code to the current upsteam version
> > : which features a significant speed improvement - benchmarking the Calgary
> > : and Silesia test corpora typically shows a doubled performance in
> > : both compression and decompression on modern i386/x86_64/powerpc machines.
> >
> > There are significant clients of the LZO library - crypto, btrfs,
> > jffs2, ubifs, squashfs and zcache. So let's give all those people a cc
> > and ask that they test the LZO changes once they land in linux-next.
> > For correctness and performance, please.
>
> The core compression and decompression code has been thoroughly tested, so I
> do not expect major problems.
>
> Good testing after the merge and feedback about build or performance issues
> (and improvements!) is highly appreciated.
The addition of the lzo tree to linux-next caused this problem for ARM
imx_v6_v7_defconfig:
In file included from /home/arnd/linux-arm/arch/arm/boot/compressed/decompress.c:40:0:
/home/arnd/linux-arm/arch/arm/boot/compressed/../../../../lib/decompress_unlzo.c:34:34: fatal error: lzo/lzo1x_decompress.c: No such file or directory
Since the file was renamed, anything including it needs to be updated to the
new file name.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
diff --git a/lib/decompress_unlzo.c b/lib/decompress_unlzo.c
index 4531294..960183d 100644
--- a/lib/decompress_unlzo.c
+++ b/lib/decompress_unlzo.c
@@ -31,7 +31,7 @@
*/
#ifdef STATIC
-#include "lzo/lzo1x_decompress.c"
+#include "lzo/lzo1x_decompress_safe.c"
#else
#include <linux/decompress/unlzo.h>
#endif
next prev parent reply other threads:[~2012-10-11 11:41 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1349621096.git.markus@oberhumer.com>
2012-10-09 19:26 ` [PATCH 0/3] Update LZO compression Andrew Morton
2012-10-09 19:54 ` Markus F.X.J. Oberhumer
2012-10-09 22:43 ` Stephen Rothwell
2012-10-11 11:41 ` Arnd Bergmann [this message]
2012-10-11 16:28 ` Markus F.X.J. Oberhumer
2012-12-21 2:03 ` Dan Magenheimer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201210111141.27270.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=adrian.hunter@intel.com \
--cc=akpm@linux-foundation.org \
--cc=andi@firstfloor.org \
--cc=dan.carpenter@oracle.com \
--cc=dan.magenheimer@oracle.com \
--cc=dedekind1@gmail.com \
--cc=dwmw2@infradead.org \
--cc=js@sig21.net \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=markus@oberhumer.com \
--cc=phillip@squashfs.org.uk \
--cc=richard.weinberger@gmail.com \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).