From: Martin Steigerwald <Martin@lichtvoll.de>
To: linux-btrfs@vger.kernel.org
Cc: Ilya Dryomov <idryomov@gmail.com>,
Goffredo Baroncelli <kreijack@gmail.com>,
Chris Mason <chris.mason@fusionio.com>,
Goffredo Baroncelli <kreijack@inwind.it>
Subject: Re: [PATCH][BTRFS-PROGS][V1] btrfs filesystem df
Date: Fri, 12 Oct 2012 11:55:02 +0200 [thread overview]
Message-ID: <201210121155.03108.Martin@lichtvoll.de> (raw)
In-Reply-To: <20121003150117.GA1978@zambezi.lan>
Am Mittwoch, 3. Oktober 2012 schrieb Ilya Dryomov:
> > $ ./btrfs filesystem df /
> > Path: /
> >
> > Summary:
> > Disk_size: 72.57GB
> > Disk_allocated: 25.10GB
> > Disk_unallocated: 47.48GB
> > Logical_size: 23.06GB
> > Used: 11.01GB
> > Free_(Estimated): 55.66GB (Max: 59.52GB, Min: 35.78GB)
> > Data_to_disk_ratio: 92 %
> >
> >
> > Details:
How about calling this "Chunks:"?
Its actually what is being displayed.
> > Chunk-type Mode Chunk-size Logical-size Used
>
> "Type" for the first column is probably enough.
Then Chunk-type can become "Type"...
> Why is the third column called Chunk-size? If my understanding is
> correct, it's just a break down of Disk_allocated from the summary
> section. If so, why not call it Disk_allocated to avoid confusion?
... and "Chunk-size" just "Size".
> Also, why do you use dashes instead of underbars for table headers?
I prefer dashes, or even spaces, but spaces are more difficult to parse.
So or so I think scripts better do not parse a user formatted output – it
sets the output format thats intended for the users viewing pleasure in
stone. Then its better to provide an option to get all of this in
parseable format. fio 2.0.10 has a JSON outputter for easy parsing, maybe
some of that can be used – in a different patch set.
Ciao,
--
Martin 'Helios' Steigerwald - http://www.Lichtvoll.de
GPG: 03B0 0D6C 0040 0710 4AFA B82F 991B EAAC A599 84C7
prev parent reply other threads:[~2012-10-12 9:55 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-03 11:43 [PATCH][BTRFS-PROGS][V1] btrfs filesystem df Goffredo Baroncelli
2012-10-03 11:43 ` [PATCH 1/2] Update btrfs filesystem df command Goffredo Baroncelli
2012-10-03 15:02 ` Ilya Dryomov
2012-10-03 16:34 ` Goffredo Baroncelli
2012-10-03 17:20 ` Ilya Dryomov
2012-10-03 17:38 ` Goffredo Baroncelli
2012-10-03 17:09 ` Goffredo Baroncelli
2012-10-03 11:43 ` [PATCH 2/2] Update help page Goffredo Baroncelli
2012-10-03 11:56 ` [PATCH][BTRFS-PROGS][V1] btrfs filesystem df Hugo Mills
2012-10-03 16:17 ` Goffredo Baroncelli
2012-10-03 16:34 ` Hugo Mills
2012-10-09 9:43 ` Bart Noordervliet
2012-10-09 11:38 ` Goffredo Baroncelli
2012-10-09 12:51 ` Bart Noordervliet
2012-10-09 18:22 ` Goffredo Baroncelli
2012-10-12 9:42 ` Martin Steigerwald
2012-10-03 15:01 ` Ilya Dryomov
2012-10-03 16:46 ` Goffredo Baroncelli
2012-10-03 17:46 ` Ilya Dryomov
2012-10-03 20:01 ` Goffredo Baroncelli
2012-10-03 20:24 ` Ilya Dryomov
2012-10-12 10:01 ` Martin Steigerwald
2012-10-12 9:55 ` Martin Steigerwald [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201210121155.03108.Martin@lichtvoll.de \
--to=martin@lichtvoll.de \
--cc=chris.mason@fusionio.com \
--cc=idryomov@gmail.com \
--cc=kreijack@gmail.com \
--cc=kreijack@inwind.it \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).