From: Martin Steigerwald <Martin@lichtvoll.de>
To: linux-btrfs@vger.kernel.org
Cc: Goffredo Baroncelli <kreijack@gmail.com>,
Hugo Mills <hugo@carfax.org.uk>,
Chris Mason <chris.mason@fusionio.com>,
David Sterba <dave@jikos.cz>
Subject: Re: [PATCH][V1][BTRFS-PROGS] Replace the units from KB to KiB..
Date: Mon, 15 Oct 2012 13:58:46 +0200 [thread overview]
Message-ID: <201210151358.46677.Martin@lichtvoll.de> (raw)
In-Reply-To: <1350156436-14439-1-git-send-email-kreijack@gmail.com>
Am Samstag, 13. Oktober 2012 schrieb Goffredo Baroncelli:
> Hi All,
>
> several people asked to update the units showed by the "btrfs" tool
> form the SI ones (KB, MB, GB...) to the IEC ones (KiB, MiB...).
>
> The aim of this patch is to allow the user to choice which units
> are showed. Depending by the BTRFS_UNIT environmental variable,
> the following units are showed:
>
> BTRFS_UNIT=SI the suffix is KB for 1000bytes, MB for 10^6 bytes...
> BTRFS_UNIT=IEC the suffix is KiB for 1024bytes, MiB for 1024 KiB ...
> BTRFS_UNIT=COMPACT the suffix is KB for 1024 bytes, MB for 1024 KiB;
> no space between the number and the suffix.
>
> BR
> G.Baroncelli
What base does this build upon?
I tried to apply upon your disk_free branch, but got:
martin@merkaba:~/Linux/Dateisysteme/BTRFS/btrfs-progs-unstable> patch -p1 < ../\[PATCH\]\[V1\]\[BTRFS-PROGS\]\ Replace\ the\ units\ from\ KB\ to\ KiB...mbox
patching file utils.c
Hunk #1 FAILED at 1085.
1 out of 1 hunk FAILED -- saving rejects to file utils.c.rej
patching file cmds-filesystem.c
Hunk #1 succeeded at 366 (offset 164 lines).
patching file cmds-scrub.c
patching file man/btrfs.8.in
Hunk #1 succeeded at 424 (offset 69 lines).
Thanks,
--
Martin 'Helios' Steigerwald - http://www.Lichtvoll.de
GPG: 03B0 0D6C 0040 0710 4AFA B82F 991B EAAC A599 84C7
next prev parent reply other threads:[~2012-10-15 11:58 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-13 19:27 [PATCH][V1][BTRFS-PROGS] Replace the units from KB to KiB Goffredo Baroncelli
2012-10-13 19:27 ` [PATCH 1/3] Add support for different unit Goffredo Baroncelli
2012-10-15 11:47 ` Martin Steigerwald
2012-10-13 19:27 ` [PATCH 2/3] Deleted the byte prefix with pretty_sizes() Goffredo Baroncelli
2012-10-13 19:27 ` [PATCH 3/3] Document the use of BTRFS_UNIT in man page Goffredo Baroncelli
2012-10-15 11:58 ` Martin Steigerwald [this message]
2012-10-15 17:02 ` [PATCH][V1][BTRFS-PROGS] Replace the units from KB to KiB Goffredo Baroncelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201210151358.46677.Martin@lichtvoll.de \
--to=martin@lichtvoll.de \
--cc=chris.mason@fusionio.com \
--cc=dave@jikos.cz \
--cc=hugo@carfax.org.uk \
--cc=kreijack@gmail.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).