From: Liu Bo <bo.li.liu@oracle.com>
To: dave@jikos.cz
Cc: miaox@cn.fujitsu.com, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH 1/2] Btrfs: fix a deadlock in aborting transaction due to ENOSPC
Date: Mon, 19 Nov 2012 15:58:55 +0800 [thread overview]
Message-ID: <20121119075853.GA31552@gmail.com> (raw)
In-Reply-To: <20121116141948.GA3102@twin.jikos.cz>
On Fri, Nov 16, 2012 at 03:19:49PM +0100, David Sterba wrote:
> On Mon, Nov 05, 2012 at 08:42:08PM +0800, Liu Bo wrote:
> > When committing a transaction, we may bail out of running delayed refs
> > due to ENOSPC, and then abort the current transaction to flip into readonly.
> >
> > But we'll hit a deadlock on ref head's lock since we forget to release
> > its lock and other cleanup stuff.
>
> Miao sent a patch for this on Tue, 08 May 2012
>
> http://www.mail-archive.com/linux-btrfs@vger.kernel.org/msg16361.html
>
> and it does more things than just the unlock, I can't tell which one of
> the patches is the right one, only letting you know.
>
Thanks for pointing that, David. Yes, that patch will work.
Miao, can you send it here again?
[PATCH] Btrfs: fix deadlock when the process of delayed refs fails
thanks,
liubo
> david
> --
> To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2012-11-19 7:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-05 12:42 [PATCH 1/2] Btrfs: fix a deadlock in aborting transaction due to ENOSPC Liu Bo
2012-11-05 12:42 ` [PATCH 2/2] Btrfs: fix a double free on pending snapshots in error handling Liu Bo
2012-11-16 14:21 ` David Sterba
2012-11-16 14:19 ` [PATCH 1/2] Btrfs: fix a deadlock in aborting transaction due to ENOSPC David Sterba
2012-11-19 7:58 ` Liu Bo [this message]
2012-11-19 8:17 ` Miao Xie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121119075853.GA31552@gmail.com \
--to=bo.li.liu@oracle.com \
--cc=dave@jikos.cz \
--cc=linux-btrfs@vger.kernel.org \
--cc=miaox@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).