From: Liu Bo <bo.li.liu@oracle.com>
To: btrfs <linux-btrfs@vger.kernel.org>
Cc: Marios Titas <redneb8888@gmail.com>, dsterba@suse.cz
Subject: Re: per-file NOCOW in 3.7
Date: Thu, 22 Nov 2012 09:16:54 +0800 [thread overview]
Message-ID: <20121122011653.GC3327@gmail.com> (raw)
In-Reply-To: <20121121172511.GC3102@twin.jikos.cz>
On Wed, Nov 21, 2012 at 06:25:11PM +0100, David Sterba wrote:
> On Wed, Nov 21, 2012 at 10:48:08AM -0500, Marios Titas wrote:
> > According to the tentative changelog in the wiki, 3.7 will properly
> > support per-file NOCOW. I think this is misleading. In particular, it
> > still does not work correctly in the case when the NOCOW flag of a new
> > flag is being inherited from the directory. I think it would be better
> > to remove that item from the changelog until the the fix [1] is
> > merged.
> > [1] https://patchwork.kernel.org/patch/1438431/
>
> You're right, the patch is not in 3.7-rc nor in btrfs-next, and fixes a
> real bug.
>
> Technically it is a regresssion within the 3.7 cycle (so it could even
> go to a late -rc), in any case it's a small change that could also go
> through the stable tree.
>
> david
Well, I'll resend it for merge with Marios's reported-by and your Reviewed-by.
Don't worry, it's a good fix though.
thanks,
liubo
next prev parent reply other threads:[~2012-11-22 19:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-21 15:48 per-file NOCOW in 3.7 Marios Titas
2012-11-21 17:25 ` David Sterba
2012-11-22 1:16 ` Liu Bo [this message]
2012-11-23 20:54 ` Sergei Trofimovich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121122011653.GC3327@gmail.com \
--to=bo.li.liu@oracle.com \
--cc=dsterba@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
--cc=redneb8888@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).