linux-btrfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Liu Bo <bo.li.liu@oracle.com>
To: David Arendt <admin@prnet.org>
Cc: linux-btrfs@vger.kernel.org
Subject: Re: extended attributes wiredness
Date: Mon, 26 Nov 2012 10:54:47 +0800	[thread overview]
Message-ID: <20121126025439.GA5923@liubo> (raw)
In-Reply-To: <50B27C4A.7040702@prnet.org>

On Sun, Nov 25, 2012 at 09:15:06PM +0100, David Arendt wrote:
> Hi,
> 
> I have made some more tests:
> 
> ./testxattr /u00/root.20121121.210102.full/var/lib/nfs/sm
> processing file /u00/root.20121121.210102.full/var/lib/nfs/sm
> processing attribute system.posix_acl_default
> lgetxattr failed: No data available
> 
> getfattr /u00/root.20121121.210102.full/var/lib/nfs/sm
> (no result)
> 
> setfattr -x system.posix_acl_default
> /u00/root.20121121.210102.full/var/lib/nfs/sm
> 
> testxattr /u00/root.20121121.210102.full/var/lib/nfs/sm
> processing file /u00/root.20121121.210102.full/var/lib/nfs/sm
> processing attribute system.posix_acl_access
> 
> setfattr -x system.posix_acl_access
> /u00/root.20121121.210102.full/var/lib/nfs/sm
> 
> ./testxattr /u00/root.20121121.210102.full/var/lib/nfs/sm
> processing file /u00/root.20121121.210102.full/var/lib/nfs/sm
> 
> Now a test with a manually set attribute:
> 
> setfattr -n user.testattribute -v testvalue
> /u00/root.20121121.210102.full/var/lib/nfs/sm
> 
> getfattr /u00/root.20121121.210102.full/var/lib/nfs/sm
> getfattr: Removing leading '/' from absolute path names
> # file: u00/root.20121121.210102.full/var/lib/nfs/sm
> user.testattribute
> 
> ./testxattr /u00/root.20121121.210102.full/var/lib/nfs/smprocessing file
> /u00/root.20121121.210102.full/var/lib/nfs/sm
> processing attribute user.testattribute
> value testvalue

So another manually set attribute proves the code is right, that means
the previous weird case is likely due to xattr metadata corruption somehow,
it maybe name hash mismatch, or the xattr name len mismatch.

thanks,
liubo

> 
> Thanks in advance,
> David Arendt
> 
> On 11/24/12 04:39, Liu Bo wrote:
> > On Fri, Nov 23, 2012 at 10:09:16PM +0100, David Arendt wrote:
> >> Well, this is only code to demonstrate the problem, the ; is normally a
> >> silly mistake, but for my test case valuelen is < 0 so, the ; doesn't
> >> change anything. With this corrected, the problem stays the same.
> >>
> >> On 11/23/12 21:43, Garry T. Williams wrote:
> >>> On Friday, November 23, 2012 18:45:04 David Arendt wrote:
> >>>>   for (i = 0; i < attrslen; i+= strlen(&attrs[i]) + 1)
> >>>>   {
> >>>>     printf("processing attribute %s\n", &attrs[i]);
> >>>>
> >>>>     valuelen = lgetxattr(argv[1], &attrs[i], value, 1024);
> >>>>
> >>>>     if (valuelen < 0);
> >>>   Hmmm ----------------^
> > Hi David,
> >
> > Any dmesg output for this?
> >
> > thanks,
> > liubo
> >
> >>>
> >>>
> >> --
> >> To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
> >> the body of a message to majordomo@vger.kernel.org
> >> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
> > the body of a message to majordomo@vger.kernel.org
> > More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

  reply	other threads:[~2012-11-26  2:57 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-23 17:45 extended attributes wiredness David Arendt
2012-11-23 20:43 ` Garry T. Williams
2012-11-23 21:09   ` David Arendt
2012-11-24  3:39     ` Liu Bo
2012-11-24  7:17       ` David Arendt
2012-11-25 20:15       ` David Arendt
2012-11-26  2:54         ` Liu Bo [this message]
2012-11-26  5:38           ` David Arendt
2012-11-27  7:46             ` Liu Bo
2012-11-27 16:53               ` David Arendt
2012-11-27 19:20               ` David Arendt
2012-11-28 10:54                 ` Liu Bo
2012-11-28 11:12                   ` Rock Lee
2012-11-28 17:11                   ` David Arendt
2012-11-27 21:18               ` David Arendt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20121126025439.GA5923@liubo \
    --to=bo.li.liu@oracle.com \
    --cc=admin@prnet.org \
    --cc=linux-btrfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).