From: Liu Bo <bo.li.liu@oracle.com>
To: Josef Bacik <jbacik@fusionio.com>
Cc: "linux-btrfs@vger.kernel.org" <linux-btrfs@vger.kernel.org>
Subject: Re: [PATCH] Btrfs: no full sync flag on new inode when we do not reuse inode id
Date: Wed, 12 Dec 2012 23:55:40 +0800 [thread overview]
Message-ID: <20121212155538.GA2379@liubo> (raw)
In-Reply-To: <20121212145004.GC3152@localhost.localdomain>
On Wed, Dec 12, 2012 at 09:50:04AM -0500, Josef Bacik wrote:
> On Tue, Dec 11, 2012 at 06:43:04PM -0700, Liu Bo wrote:
> > On Tue, Dec 11, 2012 at 10:01:17AM -0500, Josef Bacik wrote:
> > > On Thu, Dec 06, 2012 at 08:11:54PM -0700, Liu Bo wrote:
> > > > When we are not with inode_cache option, we won't reuse inode id, which
> > > > means all of inodes will own different inode id, thus we don't worry
> > > > about "reuse of inode id leads to log tree's corruption" thing.
> > > >
> > > > Signed-off-by: Liu Bo <bo.li.liu@oracle.com>
> > >
> > > With the new fsync stuff I have I still need to make sure all new xattrs and
> > > such are on disk so this needs to stay the way it is. Thanks,
> >
> > So with new fsync we cannot bare any old items even if their keys's
> > objectid(actually inode id) are different, is it right?
> >
>
> No its more that I need to know that I should log everything related to the
> inode, xattrs and all. Otherwise I'll just log the inode item and make selinux
> very sad. Thanks,
>
> Josef
Oh, I see, I've mixed with another different problem, sorry.
thanks,
liubo
prev parent reply other threads:[~2012-12-12 15:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-07 3:11 [PATCH] Btrfs: no full sync flag on new inode when we do not reuse inode id Liu Bo
2012-12-11 15:01 ` Josef Bacik
2012-12-12 1:43 ` Liu Bo
2012-12-12 14:50 ` Josef Bacik
2012-12-12 15:55 ` Liu Bo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121212155538.GA2379@liubo \
--to=bo.li.liu@oracle.com \
--cc=jbacik@fusionio.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).