From: Chris Mason <chris.mason@fusionio.com>
To: Chris Mason <clmason@fusionio.com>
Cc: David Sterba <dave@jikos.cz>, Pascal Junod <pascal@junod.info>,
linux-btrfs <linux-btrfs@vger.kernel.org>
Subject: Re: [btrfs] is vulnerable to a hash-DoS attack
Date: Fri, 14 Dec 2012 09:29:32 -0500 [thread overview]
Message-ID: <20121214142932.GB19606@shiny> (raw)
In-Reply-To: <20121213220727.GC27308@shiny>
On Thu, Dec 13, 2012 at 03:07:27PM -0700, Chris Mason wrote:
> On Thu, Dec 13, 2012 at 02:34:30PM -0700, David Sterba wrote:
> > On Thu, Dec 13, 2012 at 03:52:08PM -0500, Chris Mason wrote:
> > > Thanks for taking the time to write this up. As far as I can tell, the
> > > looping was actually fixed in an older kernel and I just misread our
> > > version string in your original email.
> >
> > Yeah, the blogpost says 3.3.7. I did a quick test with 3.7 and was not
> > able to reproduce it.
>
> I tried with 3.3 and every step between 3.3 and 3.7. I'm not able to
> reproduce the problem, and I did run with Hack=True in the script
> (thanks for the flag btw, I really like that).
>
> So, that leaves us with a few possibilities:
>
> 1) mount -o seclabel
> 2) The small size of the device
> 3) loopback
>
> I ran with a 1GB FS here on 3.3 and wasn't able to trigger things. But
> Pascal, could you please help narrow the problem down?
Ok, I think what was happening on Pascal's machine is that we are
returning -EOVERFLOW and sometimes aborting the transaction (which turns
the FS readonly).
I have that fixed here. Rename I'm reodering the rename code a little
bit to also handle the case where there are collisions on rename.
-chris
next prev parent reply other threads:[~2012-12-14 14:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-13 12:56 [btrfs] is vulnerable to a hash-DoS attack Pascal Junod
2012-12-13 20:52 ` Chris Mason
2012-12-13 21:34 ` David Sterba
2012-12-13 22:07 ` Chris Mason
2012-12-14 14:29 ` Chris Mason [this message]
2012-12-14 16:41 ` Pascal Junod
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121214142932.GB19606@shiny \
--to=chris.mason@fusionio.com \
--cc=clmason@fusionio.com \
--cc=dave@jikos.cz \
--cc=linux-btrfs@vger.kernel.org \
--cc=pascal@junod.info \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox