From: Liu Bo <bo.li.liu@oracle.com>
To: Zach Brown <zab@zabbo.net>
Cc: linux-btrfs@vger.kernel.org
Subject: Re: [PATCH 1/2] Btrfs: add leak debug for extent map
Date: Sun, 13 Jan 2013 20:18:19 +0800 [thread overview]
Message-ID: <20130113121817.GA2784@liubo> (raw)
In-Reply-To: <20130111205432.GK12288@lenny.home.zabbo.net>
On Fri, Jan 11, 2013 at 12:54:32PM -0800, Zach Brown wrote:
> > But after flipping slab code, I find that another callback will disable
> > merging slabs when allocating a slab, so I'm not sure if it worth doing so...
>
> Do you mean the find_mergeable() stuff in SLUB?
Yes, that's what I'm worried about.
>
> > What do you think about it?
>
> I don't know, pass in a callback to destruction?
>
> void kmem_cache_destroy_inuse_cb(struct kmem_cache *s,
> void (*objcb)(void *));
>
> I'd try to spend as little time on this as possible. Get the most basic
> thing working to demonstrate the idea and send it to lkml to get
> feedback.
>
> - z
Okay, I'll send a RFC, and thanks for the suggestion :)
thanks,
liubo
prev parent reply other threads:[~2013-01-13 12:20 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-08 14:49 [PATCH 1/2] Btrfs: add leak debug for extent map Liu Bo
2013-01-08 14:49 ` [PATCH 2/2] Btrfs: fix memory leak on extent map after fsync Liu Bo
2013-01-24 16:44 ` Josef Bacik
2013-01-25 1:38 ` Liu Bo
2013-01-25 2:23 ` Liu Bo
2013-01-24 16:52 ` Josef Bacik
2013-01-08 20:07 ` [PATCH 1/2] Btrfs: add leak debug for extent map Zach Brown
2013-01-10 2:05 ` Liu Bo
2013-01-10 11:54 ` David Sterba
2013-01-10 13:11 ` Liu Bo
2013-01-11 15:31 ` David Sterba
2013-01-10 17:06 ` Zach Brown
2013-01-11 8:45 ` Liu Bo
2013-01-11 20:54 ` Zach Brown
2013-01-13 12:18 ` Liu Bo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130113121817.GA2784@liubo \
--to=bo.li.liu@oracle.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=zab@zabbo.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).