linux-btrfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Josef Bacik <jbacik@fusionio.com>
To: Liu Bo <bo.li.liu@oracle.com>
Cc: "linux-btrfs@vger.kernel.org" <linux-btrfs@vger.kernel.org>
Subject: Re: [PATCH 2/2] Btrfs: fix memory leak on extent map after fsync
Date: Thu, 24 Jan 2013 11:52:10 -0500	[thread overview]
Message-ID: <20130124165210.GF2349@localhost.localdomain> (raw)
In-Reply-To: <1357656561-24604-2-git-send-email-bo.li.liu@oracle.com>

On Tue, Jan 08, 2013 at 07:49:21AM -0700, Liu Bo wrote:
> During fsync, we put the changed parts(i.e. extent map) into the log tree,
> and we ship these parts from a list of modified_extents to a local list
> to process, of course, we must increment the refs of the extent maps to
> avoid it from getting evicted from cache.
> 
> The problem is
> we don't hold the tree writer lock all the time of iterating the local list,
> and it is possible that other threads hack in and delete the extent map from
> the local list silently.  So we'll end up with memory leak here.
> 
> I hit this when testing xfstest 274 with mount options 'autodefrag,compress=zlib'.
> 
> With this fix, the memory leak has gone away.
> 

And actually I fixed this in one of my other fsync patches that didn't get
pulled in yet, so I'll break it out of that patch and we can send that along.
Thanks,

Josef

  parent reply	other threads:[~2013-01-24 16:52 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-08 14:49 [PATCH 1/2] Btrfs: add leak debug for extent map Liu Bo
2013-01-08 14:49 ` [PATCH 2/2] Btrfs: fix memory leak on extent map after fsync Liu Bo
2013-01-24 16:44   ` Josef Bacik
2013-01-25  1:38     ` Liu Bo
2013-01-25  2:23       ` Liu Bo
2013-01-24 16:52   ` Josef Bacik [this message]
2013-01-08 20:07 ` [PATCH 1/2] Btrfs: add leak debug for extent map Zach Brown
2013-01-10  2:05   ` Liu Bo
2013-01-10 11:54     ` David Sterba
2013-01-10 13:11       ` Liu Bo
2013-01-11 15:31         ` David Sterba
2013-01-10 17:06     ` Zach Brown
2013-01-11  8:45       ` Liu Bo
2013-01-11 20:54         ` Zach Brown
2013-01-13 12:18           ` Liu Bo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130124165210.GF2349@localhost.localdomain \
    --to=jbacik@fusionio.com \
    --cc=bo.li.liu@oracle.com \
    --cc=linux-btrfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).