From: Roman Mamedov <rm@romanrm.ru>
To: Gene Czarcinski <gene@czarc.net>
Cc: linux-btrfs@vger.kernel.org
Subject: Re: [PATCH] Btrfs-progs: Exit if not running as root
Date: Fri, 25 Jan 2013 17:55:30 +0600 [thread overview]
Message-ID: <20130125175530.75402fb5@natsu> (raw)
In-Reply-To: <1359113550-23962-1-git-send-email-gene@czarc.net>
[-- Attachment #1: Type: text/plain, Size: 1980 bytes --]
On Fri, 25 Jan 2013 06:32:30 -0500
Gene Czarcinski <gene@czarc.net> wrote:
> This patch hits a lot of files but adds little code. It
> could be considered a bugfix, Currently, when one of the
> btrfs user-space programs is executed by a regular user,
> the result if oftem a number of strange error messages
> which do not indicate the real problem. This patch changes
> that situation.
>
> A test is performed as to whether the program is running
> as root. If it is not, issue an error message and exit.
> Signed-off-by: Gene Czarcinski <gene@czarc.net>
$ ls -la /dev/sda
brw-rw---T 1 root disk 8, 0 Jan 15 12:11 /dev/sda
The user does not have to be root, they can be a member of the group "disk" to
manage this device.
Also some or all of the tools accept not just a block device, but also a
regular file as their parameter.
Wouldn't it be better to check whether or not the running user has
*write access* to the device or file to be operated on, before failing?
> ---
> btrfs-corrupt-block.c | 5 +++++
> btrfs-image.c | 5 +++++
> btrfs-map-logical.c | 5 +++++
> btrfs-select-super.c | 5 +++++
> btrfs-show-super.c | 5 +++++
> btrfs-show.c | 5 +++++
> btrfs-vol.c | 5 +++++
> btrfs-zero-log.c | 5 +++++
> btrfs.c | 6 ++++++
> btrfsck.c | 5 +++++
> btrfsctl.c | 5 +++++
> btrfstune.c | 5 +++++
> calc-size.c | 5 +++++
> convert.c | 6 ++++++
> debug-tree.c | 5 +++++
> dir-test.c | 5 +++++
> find-root.c | 5 +++++
> ioctl-test.c | 6 ++++++
> mkfs.c | 5 +++++
> quick-test.c | 6 ++++++
> restore.c | 5 +++++
> 21 files changed, 109 insertions(+)
--
With respect,
Roman
~~~~~~~~~~~~~~~~~~~~~~~~~~~
"Stallman had a printer,
with code he could not see.
So he began to tinker,
and set the software free."
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
next prev parent reply other threads:[~2013-01-25 11:55 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-25 11:32 [PATCH] Btrfs-progs: Exit if not running as root Gene Czarcinski
2013-01-25 11:41 ` Stefan Behrens
2013-01-25 12:03 ` Gene Czarcinski
2013-01-25 12:17 ` Stefan Behrens
2013-01-25 13:22 ` Gene Czarcinski
2013-01-25 11:55 ` Roman Mamedov [this message]
2013-01-25 12:29 ` Gene Czarcinski
2013-01-25 12:43 ` Hugo Mills
2013-01-25 15:19 ` Brendan Hide
2013-01-25 13:00 ` Roman Mamedov
2013-01-25 13:52 ` Russell Coker
2013-01-25 15:04 ` Gene Czarcinski
2013-01-25 15:10 ` Gene Czarcinski
2013-01-25 15:30 ` cwillu
2013-01-25 16:06 ` Eric Sandeen
2013-01-26 2:18 ` Russell Coker
2013-01-26 7:46 ` Goffredo Baroncelli
2013-01-25 15:07 ` Eric Sandeen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130125175530.75402fb5@natsu \
--to=rm@romanrm.ru \
--cc=gene@czarc.net \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).