From: Josef Bacik <jbacik@fusionio.com>
To: Zach Brown <zab@zabbo.net>
Cc: Josef Bacik <JBacik@fusionio.com>,
"linux-btrfs@vger.kernel.org" <linux-btrfs@vger.kernel.org>
Subject: Re: [PATCH] Btrfs: do not merge logged extents if we've removed them from the tree
Date: Mon, 28 Jan 2013 14:19:41 -0500 [thread overview]
Message-ID: <20130128191941.GF3257@localhost.localdomain> (raw)
In-Reply-To: <20130128185226.GM14246@lenny.home.zabbo.net>
On Mon, Jan 28, 2013 at 11:52:26AM -0700, Zach Brown wrote:
> > problem is we unconditionally try to merge it back into the em tree, but if
> > we've removed it from the em tree that will cause problems. So fix this by
>
> What problems? If I were staring at the symptoms of this bug how would
> I find that this commit fixes it?
>
I'll fix the commit message, we just add something to the tree that doesn't have
a ref so it's a basic use after free sort of scenario. Thanks,
Josef
> - z
next prev parent reply other threads:[~2013-01-28 19:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-28 14:52 [PATCH] Btrfs: do not merge logged extents if we've removed them from the tree Josef Bacik
2013-01-28 18:52 ` Zach Brown
2013-01-28 19:19 ` Josef Bacik [this message]
2013-01-28 19:20 ` Zach Brown
2013-01-29 2:31 ` Liu Bo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130128191941.GF3257@localhost.localdomain \
--to=jbacik@fusionio.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=zab@zabbo.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox