From: Josef Bacik <jbacik@fusionio.com>
To: Filipe Brandenburger <filbranden@google.com>
Cc: Josef Bacik <JBacik@fusionio.com>,
linux-btrfs <linux-btrfs@vger.kernel.org>
Subject: Re: [PATCH] Btrfs: fix missing i_size update
Date: Wed, 30 Jan 2013 15:07:41 -0500 [thread overview]
Message-ID: <20130130200741.GK3660@localhost.localdomain> (raw)
In-Reply-To: <CADU+-uCv+wG7vt-8gwHUwNboRpBVg7e5pNJyT3KP=yrdd32-AA@mail.gmail.com>
On Wed, Jan 30, 2013 at 12:36:22PM -0700, Filipe Brandenburger wrote:
> On Wed, Jan 30, 2013 at 11:28 AM, Josef Bacik <jbacik@fusionio.com> wrote:
> > + /*
> > + * We still need to update disk_i_size if outstanding_isize is greater
> > + * than disk_i_size.
> > + */
> > + if (offset <= disk_i_size &&
> > + (!ordered || ordered->outstanding_isize < disk_i_size))
>
> "<=" for the comparison? "ordered->outstanding_isize <= disk_i_size"
>
Yeah good point. Thanks,
Josef
prev parent reply other threads:[~2013-01-30 20:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-30 19:28 [PATCH] Btrfs: fix missing i_size update Josef Bacik
2013-01-30 19:36 ` Filipe Brandenburger
2013-01-30 20:07 ` Josef Bacik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130130200741.GK3660@localhost.localdomain \
--to=jbacik@fusionio.com \
--cc=filbranden@google.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox