From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.vapor.com ([83.220.149.2]:36292 "EHLO nitrogen.vapor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754416Ab3A3VL6 (ORCPT ); Wed, 30 Jan 2013 16:11:58 -0500 Date: Wed, 30 Jan 2013 22:11:44 +0100 From: Ian Kumlien To: Filipe Brandenburger Cc: Ian Kumlien , linux-btrfs Subject: Re: [PATCH] [RFC] include btrfsck in btrfs - including "name check" Message-ID: <20130130211144.GJ15780@pomac.netswarm.net> References: <1359500633-7219-1-git-send-email-pomac@demius.net> <1359500633-7219-2-git-send-email-pomac@demius.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: Sender: linux-btrfs-owner@vger.kernel.org List-ID: On Wed, Jan 30, 2013 at 12:33:42PM -0800, Filipe Brandenburger wrote: > Hi Ian, > > On Tue, Jan 29, 2013 at 3:03 PM, Ian Kumlien wrote: > > This patch includes fsck as a subcommand of btrfs, but if you rename > > the binary to btrfsck (or, preferably, use a symlink) it will act like > > the old btrfs command. > > You can rename files in your git (there's "git mv" for that), only > thing is when you generate the patch with format-patch (or "git show", > "git diff" etc.) pass it the -M option to detect moves and act > appropriately. git send-email seems to send the full diff, diffing against /dev/null =P This is why i skipped that part. > Regarding your patches, I really like the idea of "btrfs fsck" but I > think I'd prefer to keep the external commands as wrapper scripts > instead of adding busybox-style name detection to btrfs... But then, > that's just my opinion. Well, now both works. > I guess I would have a "btrfsck" that would simply contain: > > #! /bin/sh > exec btrfs fsck "$@" > > Downside is that error reporting (e.g. invalid syntax, etc.) would > show "btrfs fsck" instead of the command the user actually typed... Actually it still does, due to how btrfs handles things... It's a simple enough fix and it will make rescue cd's or dracut images, or just about anything. I understand your point, but i think this is a simpler solution =) > Cheers, > Filipe