From: Josef Bacik <jbacik@fusionio.com>
To: Zach Brown <zab@zabbo.net>
Cc: Josef Bacik <JBacik@fusionio.com>,
"linux-btrfs@vger.kernel.org" <linux-btrfs@vger.kernel.org>
Subject: Re: [PATCH] Btrfs: fix how we discard outstanding ordered extents on abort
Date: Thu, 31 Jan 2013 15:15:49 -0500 [thread overview]
Message-ID: <20130131201549.GB11835@localhost.localdomain> (raw)
In-Reply-To: <20130131195808.GG14246@lenny.home.zabbo.net>
On Thu, Jan 31, 2013 at 12:58:08PM -0700, Zach Brown wrote:
> > - struct list_head splice;
> > struct btrfs_ordered_extent *ordered;
>
> > struct inode *inode;
>
> Remove this too?
>
> > + /*
> > + * This will just short circuit the ordered completion stuff which will
> > + * make sure the ordered extent gets properly cleaned up.
> > + */
> > + list_for_each_entry(ordered, &root->fs_info->ordered_extents,
> > + root_extent_list)
> > + set_bit(BTRFS_ORDERED_IOERR, &ordered->flags);
> > spin_unlock(&root->fs_info->ordered_extent_lock);
> > }
>
> fs/btrfs/disk-io.c: In function ‘btrfs_destroy_ordered_extents’:
> fs/btrfs/disk-io.c:3548:16: warning: unused variable ‘inode’ [-Wunused-variable]
>
Sigh I sent the wrong thing out, the one committed to my tree is right. Thanks,
Josef
prev parent reply other threads:[~2013-01-31 20:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-31 19:32 [PATCH] Btrfs: fix how we discard outstanding ordered extents on abort Josef Bacik
2013-01-31 19:58 ` Zach Brown
2013-01-31 20:15 ` Josef Bacik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130131201549.GB11835@localhost.localdomain \
--to=jbacik@fusionio.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=zab@zabbo.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).