From: Josef Bacik <jbacik@fusionio.com>
To: Miao Xie <miaox@cn.fujitsu.com>
Cc: Linux Btrfs <linux-btrfs@vger.kernel.org>
Subject: Re: [PATCH] Btrfs: fix the deadlock between the transaction attach and commit
Date: Tue, 12 Feb 2013 09:39:01 -0500 [thread overview]
Message-ID: <20130212143901.GC2611@localhost.localdomain> (raw)
In-Reply-To: <5114A177.5020604@cn.fujitsu.com>
On Thu, Feb 07, 2013 at 11:55:51PM -0700, Miao Xie wrote:
> Here is the whole story:
> Trans_Attach_Task Trans_Commit_Task
> btrfs_commit_transaction()
> |->wait writers to be 1
> btrfs_attach_transaction() |
> btrfs_commit_transaction() |
> | |->set trans_no_join to 1
> | | (close join transaction)
> |->btrfs_run_ordered_operations |
> (Those ordered operations |
> are added when releasing |
> file) |
> |->btrfs_join_transaction() |
> |->wait_commit() |
> |->wait writers to be 1
I'm just dropping this patch, the way you describe this deadlock can't happen
since the second btrfs_join_transaction() would see theres already a
transaction in current->journal_info and use that and not do wait_commit(). If
you observed a deadlock like this then look at it again, there is something else
going wrong. Thanks,
Josef
prev parent reply other threads:[~2013-02-12 14:39 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-08 6:55 [PATCH] Btrfs: fix the deadlock between the transaction attach and commit Miao Xie
2013-02-11 20:35 ` Josef Bacik
2013-02-12 12:56 ` David Sterba
2013-02-18 10:36 ` Miao Xie
2013-02-12 14:39 ` Josef Bacik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130212143901.GC2611@localhost.localdomain \
--to=jbacik@fusionio.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=miaox@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).