From: Chris Mason <chris.mason@fusionio.com>
To: David Sterba <dsterba@suse.cz>
Cc: "linux-btrfs@vger.kernel.org" <linux-btrfs@vger.kernel.org>
Subject: Re: [PATCH] btrfs: try harder to allocate raid56 stripe cache
Date: Fri, 1 Mar 2013 10:14:26 -0500 [thread overview]
Message-ID: <20130301151426.GA10225@shiny.masoncoding.com> (raw)
In-Reply-To: <1362150180-13792-1-git-send-email-dsterba@suse.cz>
On Fri, Mar 01, 2013 at 08:03:00AM -0700, David Sterba wrote:
> The stripe hash table is large, starting with allocation order 4 and can go as
> high as order 7 in case lock debugging is turned on and structure padding
> happens.
Thanks Dave, I had this on my todo list but it dropped off. We don't
really need the stripe cache for most mounts. The code was initially
setup to only allocate it when we read a raid5/6 block group, but I ran
into trouble for the sys array.
Still, it should really be changed to only load the cache when we hit
raid5/6 goodness.
-chris
next prev parent reply other threads:[~2013-03-01 15:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-01 15:03 [PATCH] btrfs: try harder to allocate raid56 stripe cache David Sterba
2013-03-01 15:14 ` Chris Mason [this message]
2013-03-01 15:33 ` David Sterba
2013-03-01 18:18 ` Zach Brown
2013-03-01 23:35 ` David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130301151426.GA10225@shiny.masoncoding.com \
--to=chris.mason@fusionio.com \
--cc=dsterba@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox