linux-btrfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Chris Mason <chris.mason@fusionio.com>
To: Liu Bo <bo.li.liu@oracle.com>
Cc: Chris Mason <clmason@fusionio.com>,
	Linux Btrfs List <linux-btrfs@vger.kernel.org>,
	Miao Xie <miaox@cn.fujitsu.com>
Subject: Re: [PATCH] Btrfs: improve the delayed inode throttling
Date: Tue, 5 Mar 2013 20:51:15 -0500	[thread overview]
Message-ID: <20130306015115.GD6904@shiny.masoncoding.com> (raw)
In-Reply-To: <20130306003733.GB3151@liubo.jp.oracle.com>

On Tue, Mar 05, 2013 at 05:37:34PM -0700, Liu Bo wrote:
> On Tue, Mar 05, 2013 at 10:40:17AM -0500, Chris Mason wrote:
> > diff --git a/fs/btrfs/delayed-inode.c b/fs/btrfs/delayed-inode.c
> > index 0b278b1..460d1a8 100644
> > --- a/fs/btrfs/delayed-inode.c
> > +++ b/fs/btrfs/delayed-inode.c
> > +			if (!signal_pending(current))
> > +				schedule();
> 
> Do we need a 'break' here?
> 
> Like
> 
> if (!signal_pending(current))
> 	schedule();
> else
> 	break;

Seems like a good idea ;)

Thanks

-chris


  reply	other threads:[~2013-03-06  1:51 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-05 15:40 [PATCH] Btrfs: improve the delayed inode throttling Chris Mason
2013-03-06  0:37 ` Liu Bo
2013-03-06  1:51   ` Chris Mason [this message]
2013-03-06  2:45 ` Miao Xie
2013-03-06 14:53   ` Chris Mason
2013-03-07  1:19     ` Miao Xie
2013-03-07  1:39     ` Miao Xie
2013-03-07  3:06       ` Chris Mason
2013-03-07  5:53         ` Miao Xie
2013-03-07 15:42           ` Chris Mason

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130306015115.GD6904@shiny.masoncoding.com \
    --to=chris.mason@fusionio.com \
    --cc=bo.li.liu@oracle.com \
    --cc=clmason@fusionio.com \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=miaox@cn.fujitsu.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).