From: Chris Mason <chris.mason@fusionio.com>
To: David Sterba <dsterba@suse.cz>
Cc: "linux-btrfs@vger.kernel.org" <linux-btrfs@vger.kernel.org>
Subject: Re: [PATCH v2] btrfs: enhance superblock checks
Date: Wed, 13 Mar 2013 15:31:19 -0400 [thread overview]
Message-ID: <20130313193119.GG15014@shiny.masoncoding.com> (raw)
In-Reply-To: <1362748538-12873-1-git-send-email-dsterba@suse.cz>
On Fri, Mar 08, 2013 at 06:15:38AM -0700, David Sterba wrote:
> The superblock checksum is not verified upon mount. <awkward silence>
>
> Add that check and also reorder existing checks to a more logical
> order.
>
> Current mkfs.btrfs does not calculate the correct checksum of
> super_block and thus a freshly created filesytem will fail to mount when
> this patch is applied.
Hi Dave,
Thanks for finding this and writing up the patch. Can we please change
it to ignore the crc if the transid is from mkfs? I'd prefer that we
allow older progs for a while longer. We can take this check out after
a few releases.
-chris
next prev parent reply other threads:[~2013-03-13 19:31 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-06 15:56 [PATCH] btrfs: enhance superblock checks David Sterba
2013-03-06 16:32 ` [PATCH] btrfs-progs: separate super_copy out of fs_info David Sterba
2013-03-06 17:14 ` [PATCH] btrfs: enhance superblock checks Blair Zajac
2013-03-06 18:33 ` David Sterba
2013-03-06 18:56 ` Zach Brown
2013-03-07 14:52 ` David Sterba
2013-03-07 17:00 ` Zach Brown
2013-03-07 9:42 ` David Sterba
2013-03-08 13:15 ` [PATCH v2] " David Sterba
2013-03-13 19:31 ` Chris Mason [this message]
2013-03-15 11:22 ` David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130313193119.GG15014@shiny.masoncoding.com \
--to=chris.mason@fusionio.com \
--cc=dsterba@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).