From: Chris Mason <chris.mason@fusionio.com>
To: Liu Bo <bo.li.liu@oracle.com>,
"linux-btrfs@vger.kernel.org" <linux-btrfs@vger.kernel.org>
Cc: "johannes.hirte@fem.tu-ilmenau.de"
<johannes.hirte@fem.tu-ilmenau.de>,
"darrick.wong@oracle.com" <darrick.wong@oracle.com>
Subject: Re: [PATCH] Btrfs: fix warning of free_extent_map
Date: Sat, 16 Mar 2013 10:35:43 -0400 [thread overview]
Message-ID: <20130316143543.5385.43571@localhost.localdomain> (raw)
In-Reply-To: <1363358799-17991-1-git-send-email-bo.li.liu@oracle.com>
Quoting Liu Bo (2013-03-15 10:46:39)
> Users report that an extent map's list is still linked when it's actually
> going to be freed from cache.
>
> The story is that
>
> a) when we're going to drop an extent map and may split this large one into
> smaller ems, and if this large one is flagged as EXTENT_FLAG_LOGGING which means
> that it's on the list to be logged, then the smaller ems split from it will also
> be flagged as EXTENT_FLAG_LOGGING, and this is _not_ expected.
>
> b) we'll keep ems from unlinking the list and freeing when they are flagged with
> EXTENT_FLAG_LOGGING, because the log code holds one reference.
>
> The end result is the warning, but the truth is that we set the flag
> EXTENT_FLAG_LOGGING only during fsync.
>
> So clear flag EXTENT_FLAG_LOGGING for extent maps split from a large one.
Thanks for tracking this down! I've got it in my tree now.
-chris
prev parent reply other threads:[~2013-03-16 14:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-15 14:46 [PATCH] Btrfs: fix warning of free_extent_map Liu Bo
2013-03-15 20:15 ` Darrick J. Wong
2013-03-16 14:35 ` Chris Mason [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130316143543.5385.43571@localhost.localdomain \
--to=chris.mason@fusionio.com \
--cc=bo.li.liu@oracle.com \
--cc=darrick.wong@oracle.com \
--cc=johannes.hirte@fem.tu-ilmenau.de \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox