From: Chris Mason <chris.mason@fusionio.com>
To: "dsterba@suse.cz" <dsterba@suse.cz>,
David Sterba <dsterba@suse.cz>, Josef Bacik <JBacik@fusionio.com>
Cc: "linux-btrfs@vger.kernel.org" <linux-btrfs@vger.kernel.org>,
Simon Kirby <sim@hostway.ca>
Subject: Re: [PATCH v2] Btrfs: Include the device in most error printk()s
Date: Thu, 21 Mar 2013 13:58:19 -0400 [thread overview]
Message-ID: <20130321175819.30044.75697@localhost.localdomain> (raw)
In-Reply-To: <20130321134950.GI31559@twin.jikos.cz>
Quoting David Sterba (2013-03-21 09:49:50)
> On Tue, Mar 19, 2013 at 03:41:23PM -0700, Simon Kirby wrote:
> > Use btrfs_printk(fs_info, format, ...) rather than writing the device
> > string every time, and introduce macro wrappers ala XFS for brevity.
> > Since the function already cannot be used for continuations, print a
> > newline as part of the btrfs_printk() message rather than at each caller.
>
> Josef, some the patches I've sent yestreday are in conflict with this
> patch, please drop them and I'll resend when this patch is merged.
I really like this patch, but we're going to have to sit on it until the
next merge window. It's fairly large and we need to stick with things
that are more clearly bug fixes for now.
But, I don't have a problem with queuing it into linux-next. After the
next rc we can get Josef's tree into the full linux-next for more
testing.
-chris
next prev parent reply other threads:[~2013-03-21 17:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-19 22:41 [PATCH v2] Btrfs: Include the device in most error printk()s Simon Kirby
2013-03-21 13:49 ` David Sterba
2013-03-21 17:58 ` Chris Mason [this message]
2013-03-22 12:05 ` David Sterba
-- strict thread matches above, loose matches on Subject: below --
2013-02-14 12:44 [PATCH] " David Sterba
2013-02-15 23:12 ` [PATCH v2] " Simon Kirby
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130321175819.30044.75697@localhost.localdomain \
--to=chris.mason@fusionio.com \
--cc=JBacik@fusionio.com \
--cc=dsterba@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
--cc=sim@hostway.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox