From: Josef Bacik <jbacik@fusionio.com>
To: Miao Xie <miaox@cn.fujitsu.com>
Cc: Linux Btrfs <linux-btrfs@vger.kernel.org>
Subject: Re: [PATCH V2 1/2] Btrfs: improve the performance of the csums lookup
Date: Thu, 4 Apr 2013 09:12:04 -0400 [thread overview]
Message-ID: <20130404131204.GQ1876@localhost.localdomain> (raw)
In-Reply-To: <515BF138.90309@cn.fujitsu.com>
On Wed, Apr 03, 2013 at 03:07:04AM -0600, Miao Xie wrote:
> It is very likely that there are several blocks in bio, it is very
> inefficient if we get their csums one by one. This patch improves
> this problem by getting the csums in batch.
>
> According to the result of the following test, the execute time of
> __btrfs_lookup_bio_sums() is down by ~28%(300us -> 217us).
>
> # dd if=<mnt>/file of=/dev/null bs=1M count=1024
>
> Signed-off-by: Miao Xie <miaox@cn.fujitsu.com>
This is panicing when I run my fsync tests and when kdave runs xfstest 91. I
don't have time to track it down now so I'm just dropping it from btrfs-next.
I'll look at it after I figure out this fsync bug unless you beat me to it.
Thanks,
Josef
next prev parent reply other threads:[~2013-04-04 13:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-28 8:10 [PATCH 2/4] Btrfs: improve the performance of the csums lookup Miao Xie
2013-03-28 14:37 ` Liu Bo
2013-04-03 9:07 ` [PATCH V2 1/2] " Miao Xie
2013-04-04 13:12 ` Josef Bacik [this message]
2013-04-05 7:20 ` [PATCH V3 " Miao Xie
2013-04-05 14:35 ` David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130404131204.GQ1876@localhost.localdomain \
--to=jbacik@fusionio.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=miaox@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox