From: Josef Bacik <jbacik@fusionio.com>
To: Liu Bo <bo.li.liu@oracle.com>
Cc: Josef Bacik <JBacik@fusionio.com>,
"linux-btrfs@vger.kernel.org" <linux-btrfs@vger.kernel.org>
Subject: Re: [PATCH] Btrfs: fix all callers of read_tree_block
Date: Wed, 24 Apr 2013 09:07:01 -0400 [thread overview]
Message-ID: <20130424130701.GG2631@localhost.localdomain> (raw)
In-Reply-To: <20130424081747.GF19283@liubo.jp.oracle.com>
On Wed, Apr 24, 2013 at 02:17:48AM -0600, Liu Bo wrote:
> On Tue, Apr 23, 2013 at 02:20:22PM -0400, Josef Bacik wrote:
> > We kept leaking extent buffers when mounting a broken file system and it turns
> > out it's because not everybody uses read_tree_block properly. You need to check
> > and make sure the extent_buffer is uptodate before you use it. This patch fixes
> > everybody who calls read_tree_block directly to make sure they check that it is
> > uptodate and free it and return an error if it is not. With this we no longer
> > leak EB's when things go horribly wrong. Thanks,
>
> What about hook the check into read_tree_block()?
>
> That way we can save much efforts.
Because other people do other things when it gets back from read_tree_block(),
the readahead code and the search ahead code to name a few. Thanks,
Josef
next prev parent reply other threads:[~2013-04-24 13:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-23 18:20 [PATCH] Btrfs: fix all callers of read_tree_block Josef Bacik
2013-04-24 8:17 ` Liu Bo
2013-04-24 13:07 ` Josef Bacik [this message]
2013-04-24 15:50 ` David Sterba
2013-07-30 15:11 ` Alex Lyakas
2013-07-30 15:40 ` Josef Bacik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130424130701.GG2631@localhost.localdomain \
--to=jbacik@fusionio.com \
--cc=bo.li.liu@oracle.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).