From: Josef Bacik <jbacik@fusionio.com>
To: Alexander Skwar <alexanders.mailinglists+nospam@gmail.com>
Cc: Josef Bacik <JBacik@fusionio.com>,
"linux-btrfs@vger.kernel.org" <linux-btrfs@vger.kernel.org>
Subject: Re: WARNING: at fs/btrfs/free-space-cache.c:921 __btrfs_write_out_cache+0x6b9/0x9a0 [btrfs]()
Date: Tue, 30 Apr 2013 13:53:51 -0400 [thread overview]
Message-ID: <20130430175351.GF2580@localhost.localdomain> (raw)
In-Reply-To: <CADn-QaMFct-5XgMbqiWMG_pa-AzgOQOZLUc-CNTrAPpG7633Aw@mail.gmail.com>
On Tue, Apr 30, 2013 at 08:33:38AM -0600, Alexander Skwar wrote:
> Hello Josef
>
> On Tue, Apr 30, 2013 at 3:58 PM, Josef Bacik <jbacik@fusionio.com> wrote:
>
> > So we deal with this case fine, but it really shouldn't be happening, it only
> > happens if your block groups are way too large, which again shouldn't be
> > happening. Can you run fsck on this device and see if it complains? Thanks,
>
>
> a@ewzw032:~$ sudo btrfsck /dev/system/Data
> checking extents
> checking fs roots
> checking root refs
> found 115308904448 bytes used err is 0
> total csum bytes: 112056692
> total tree bytes: 521891840
> total fs tree bytes: 353947648
> btree space waste bytes: 122297974
> file data blocks allocated: 114787012608
> referenced 114787000320
> Btrfs v0.20-rc1
>
Can you run this patch and capture the output when you get the warning? You
should see some mesages before the -- [ cut here ] -- part, make sure to capture
those. Thanks,
Josef
diff --git a/fs/btrfs/free-space-cache.c b/fs/btrfs/free-space-cache.c
index ecca6c7..2e8e098 100644
--- a/fs/btrfs/free-space-cache.c
+++ b/fs/btrfs/free-space-cache.c
@@ -921,6 +921,10 @@ static int __btrfs_write_out_cache(struct btrfs_root *root, struct inode *inode,
/* Make sure we can fit our crcs into the first page */
if (io_ctl.check_crcs &&
(io_ctl.num_pages * sizeof(u32)) >= PAGE_CACHE_SIZE) {
+ printk(KERN_ERR "num_pages is %d, blockgroup? %s\n",
+ io_ctl.num_pages, block_group ? "yes" : "no");
+ if (block_group)
+ printk(KERN_ERR "block group offset=%Lu, size=%Lu\n", block_group->key.objectid, block_group->key.offset);
WARN_ON(1);
goto out_nospc;
}
next prev parent reply other threads:[~2013-04-30 17:53 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-30 6:37 WARNING: at fs/btrfs/free-space-cache.c:921 __btrfs_write_out_cache+0x6b9/0x9a0 [btrfs]() Alexander Skwar
2013-04-30 6:55 ` Helmut Hullen
2013-04-30 9:41 ` Hugo Mills
2013-04-30 11:51 ` Alexander Skwar
2013-04-30 13:58 ` Josef Bacik
2013-04-30 14:33 ` Alexander Skwar
2013-04-30 17:53 ` Josef Bacik [this message]
2013-05-01 6:39 ` Alexander Skwar
2013-05-01 18:57 ` Josef Bacik
2013-05-01 19:19 ` Jon Nelson
2013-05-01 20:08 ` Alexander Skwar
[not found] ` <CADn-QaPh9EZjnbr9HoRKTMi8OUgnvfRdD7riEDZ0hpkcNRN93Q@mail.gmail.com>
2013-05-08 20:40 ` Josef Bacik
2013-05-08 20:47 ` Josef Bacik
2013-05-13 8:33 ` Alexander Skwar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130430175351.GF2580@localhost.localdomain \
--to=jbacik@fusionio.com \
--cc=alexanders.mailinglists+nospam@gmail.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox