From: Josef Bacik <jbacik@fusionio.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Josef Bacik <JBacik@fusionio.com>,
"linux-btrfs@vger.kernel.org" <linux-btrfs@vger.kernel.org>
Subject: Re: Btrfs: cleanup destroy_marked_extents
Date: Thu, 9 May 2013 08:32:36 -0400 [thread overview]
Message-ID: <20130509123236.GV12414@localhost.localdomain> (raw)
In-Reply-To: <20130509122206.GA997@elgon.mountain>
On Thu, May 09, 2013 at 06:22:06AM -0600, Dan Carpenter wrote:
> Hello Josef Bacik,
>
> This is a semi-automatic email about new static checker warnings.
>
> The patch fd8b2b611580: "Btrfs: cleanup destroy_marked_extents" from
> Apr 24, 2013, leads to the following Smatch complaint:
>
> fs/btrfs/disk-io.c:3814 btrfs_destroy_marked_extents()
> warn: variable dereferenced before check 'eb' (see line 3813)
>
> fs/btrfs/disk-io.c
> 3812 root->leafsize);
> 3813 start += eb->len;
> ^^^^^^^
> New dereference.
> 3814 if (!eb)
> ^^^
> New check. Maybe we should be adding "root->leafsize" here? Just
> the check earlier would cause a forever loop.
>
> 3815 continue;
> 3816 wait_on_extent_buffer_writeback(eb);
>
Yeah I sent a patch for it yesterday, just me being an idiot, nothing to see
here,
Josef
prev parent reply other threads:[~2013-05-09 12:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-09 12:22 Btrfs: cleanup destroy_marked_extents Dan Carpenter
2013-05-09 12:32 ` Josef Bacik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130509123236.GV12414@localhost.localdomain \
--to=jbacik@fusionio.com \
--cc=dan.carpenter@oracle.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).