From: Chris Mason <chris.mason@fusionio.com>
To: "miaox@cn.fujitsu.com" <miaox@cn.fujitsu.com>,
Miao Xie <miaox@cn.fujitsu.com>,
"bo.li.liu@oracle.com" <bo.li.liu@oracle.com>
Cc: "linux-btrfs@vger.kernel.org" <linux-btrfs@vger.kernel.org>,
"alex.btrfs@zadarastorage.com" <alex.btrfs@zadarastorage.com>
Subject: Re: [PATCH 06/17] Btrfs: introduce grab/put functions for the root of the fs/file tree
Date: Thu, 16 May 2013 07:54:17 -0400 [thread overview]
Message-ID: <20130516115417.24668.98321@localhost.localdomain> (raw)
In-Reply-To: <5194893D.90505@cn.fujitsu.com>
Quoting Miao Xie (2013-05-16 03:22:37)
> > I must say that the patch itself looks harmless, the reason is not good enough.
>
> I don't agree with you.
> It is perishing that The memory reclaim task is blocked for a long time. We should avoid
> this problem.
synchronize_rcu and friends can take a very very long time. I like this
patch as a way to avoid them, it's just keeps the whole kernel moving.
-chris
next prev parent reply other threads:[~2013-05-16 11:54 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-15 7:48 [PATCH 00/17] improve the block time during the transaction commit Miao Xie
2013-05-15 7:48 ` [PATCH 01/17] Btrfs: fix accessing a freed tree root Miao Xie
2013-05-15 7:48 ` [PATCH 02/17] Btrfs: fix unprotected root node of the subvolume's inode rb-tree Miao Xie
2013-05-15 7:48 ` [PATCH 03/17] Btrfs: pause the space balance when remounting to R/O Miao Xie
2013-05-15 7:48 ` [PATCH 04/17] Btrfs: remove BUG_ON() in btrfs_read_fs_tree_no_radix() Miao Xie
2013-05-15 7:48 ` [PATCH 05/17] Btrfs: cleanup the similar code of the fs root read Miao Xie
2013-05-15 7:48 ` [PATCH 06/17] Btrfs: introduce grab/put functions for the root of the fs/file tree Miao Xie
2013-05-16 3:36 ` Liu Bo
2013-05-16 4:31 ` Miao Xie
2013-05-16 5:15 ` Liu Bo
2013-05-16 5:34 ` Miao Xie
2013-05-16 6:15 ` Liu Bo
2013-05-16 7:22 ` Miao Xie
2013-05-16 11:54 ` Chris Mason [this message]
2013-05-16 14:31 ` Liu Bo
2013-05-16 14:34 ` Chris Mason
2013-05-16 14:57 ` Liu Bo
2013-05-17 1:50 ` Miao Xie
2013-05-16 12:05 ` Liu Bo
2013-05-15 7:48 ` [PATCH 07/17] Btrfs: don't invoke btrfs_invalidate_inodes() in the spin lock context Miao Xie
2013-05-15 7:48 ` [PATCH 08/17] Btrfs: introduce per-subvolume delalloc inode list Miao Xie
2013-05-15 7:48 ` [PATCH 09/17] Btrfs: introduce per-subvolume ordered extent list Miao Xie
2013-05-15 7:48 ` [PATCH 10/17] Btrfs: just flush the delalloc inodes in the source tree before snapshot creation Miao Xie
2013-05-16 3:20 ` Liu Bo
2013-05-16 4:00 ` Miao Xie
2013-05-15 7:48 ` [PATCH 11/17] Btrfs: cleanup unnecessary assignment when cleaning up all the residual transaction Miao Xie
2013-05-15 7:48 ` [PATCH 12/17] Btrfs: remove the code for the impossible case in cleanup_transaction() Miao Xie
2013-05-15 7:48 ` [PATCH 13/17] Btrfs: don't wait for all the writers circularly during the transaction commit Miao Xie
2013-05-15 7:48 ` [PATCH 14/17] Btrfs: don't flush the delalloc inodes in the while loop if flushoncommit is set Miao Xie
2013-05-15 7:48 ` [PATCH 15/17] Btrfs: remove unnecessary varient ->num_joined in btrfs_transaction structure Miao Xie
2013-05-15 7:48 ` [PATCH 16/17] Btrfs: remove the time check in btrfs_commit_transaction() Miao Xie
2013-05-15 7:48 ` [PATCH 17/17] Btrfs: make the state of the transaction more readable Miao Xie
2013-05-17 3:53 ` [PATCH V2 " Miao Xie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130516115417.24668.98321@localhost.localdomain \
--to=chris.mason@fusionio.com \
--cc=alex.btrfs@zadarastorage.com \
--cc=bo.li.liu@oracle.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=miaox@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).