From: Josef Bacik <jbacik@fusionio.com>
To: Stefan Behrens <sbehrens@giantdisaster.de>
Cc: Josef Bacik <JBacik@fusionio.com>,
"linux-btrfs@vger.kernel.org" <linux-btrfs@vger.kernel.org>
Subject: Re: [PATCH v4 6/8] Btrfs: introduce uuid-tree-gen field
Date: Fri, 7 Jun 2013 10:47:59 -0400 [thread overview]
Message-ID: <20130607144759.GF29248@localhost.localdomain> (raw)
In-Reply-To: <51B1F130.90401@giantdisaster.de>
On Fri, Jun 07, 2013 at 08:41:52AM -0600, Stefan Behrens wrote:
> On 06/07/2013 16:39, Josef Bacik wrote:
> > On Fri, Jun 07, 2013 at 04:27:51AM -0600, Stefan Behrens wrote:
> >> In order to be able to detect the case that a filesystem is mounted
> >> with an old kernel, add a uuid-tree-gen field like the free space
> >> cache is doing it. It is part of the super block and written with
> >> each commit. Old kernels do not know this field and don't update it.
> >>
> >
> > So to get around the whole crashing before we finish creating the uuid tree
> > maybe set some flag or something that doesn't actually set the
> > super->uuid_tree_generation until _after_ it finishes populating the tree, and
> > then have the scan deal with having a half populated tree. Just an idea, but we
> > have to deal with it some way. Thanks,
>
> That's what the patch 7/8 is doing.
>
Yeah I just noticed that, thanks.
Josef
next prev parent reply other threads:[~2013-06-07 14:48 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-07 10:27 [PATCH v4 0/8] Btrfs: introduce a tree for UUID to subvol ID mapping Stefan Behrens
2013-06-07 10:27 ` [PATCH v4 1/8] Btrfs: introduce a tree for items that map UUIDs to something Stefan Behrens
2013-06-07 10:27 ` [PATCH v4 2/8] Btrfs: support printing UUID tree elements Stefan Behrens
2013-06-07 10:27 ` [PATCH v4 3/8] Btrfs: create UUID tree if required Stefan Behrens
2013-06-07 10:27 ` [PATCH v4 4/8] Btrfs: maintain subvolume items in the UUID tree Stefan Behrens
2013-06-07 10:27 ` [PATCH v4 5/8] Btrfs: fill UUID tree initially Stefan Behrens
2013-06-07 14:36 ` Josef Bacik
2013-06-07 10:27 ` [PATCH v4 6/8] Btrfs: introduce uuid-tree-gen field Stefan Behrens
2013-06-07 14:39 ` Josef Bacik
2013-06-07 14:41 ` Stefan Behrens
2013-06-07 14:47 ` Josef Bacik [this message]
2013-06-07 10:27 ` [PATCH v4 7/8] Btrfs: check UUID tree during mount if required Stefan Behrens
2013-06-07 10:27 ` [PATCH v4 8/8] Btrfs: add mount option to force UUID tree checking Stefan Behrens
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130607144759.GF29248@localhost.localdomain \
--to=jbacik@fusionio.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=sbehrens@giantdisaster.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).