From: Josef Bacik <jbacik@fusionio.com>
To: Miao Xie <miaox@cn.fujitsu.com>
Cc: Josef Bacik <jbacik@fusionio.com>,
Linux Btrfs <linux-btrfs@vger.kernel.org>
Subject: Re: [PATCH] Btrfs: fix wrong csum clone when doing relocation
Date: Tue, 18 Jun 2013 08:23:28 -0400 [thread overview]
Message-ID: <20130618122328.GB19183@localhost.localdomain> (raw)
In-Reply-To: <51BFD061.4070404@cn.fujitsu.com>
On Tue, Jun 18, 2013 at 11:13:37AM +0800, Miao Xie wrote:
> From: Josef Bacik <jbacik@fusionio.com>
>
> Patch "Btrfs: remove btrfs_sector_sum structure" introduced a problem
> that we copied the checksum value to the wrong address when doing
> relocation.
>
> The reason is:
> It is very likely that one ordered extent has two or more checksum
> structures to keep the relative checksum value, and ->bytenr in each
> checksum structure should point to the start of its extent, not the
> start of the ordered extent. Fix it.
>
Just fold it into the original patch, since it corrupts the file system I'd
rather people not be able to bisect across them. Thanks,
Josef
next prev parent reply other threads:[~2013-06-18 12:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-06 10:17 [PATCH V3] Btrfs: remove btrfs_sector_sum structure Miao Xie
2013-06-14 15:27 ` Josef Bacik
2013-06-18 3:13 ` [PATCH] Btrfs: fix wrong csum clone when doing relocation Miao Xie
2013-06-18 12:23 ` Josef Bacik [this message]
2013-06-19 2:36 ` [PATCH V4] Btrfs: remove btrfs_sector_sum structure Miao Xie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130618122328.GB19183@localhost.localdomain \
--to=jbacik@fusionio.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=miaox@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).