linux-btrfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Hugo Mills <hugo@carfax.org.uk>
To: Gabriel de Perthuis <g2p.code@gmail.com>
Cc: linux-btrfs@vger.kernel.org
Subject: Re: Two identical copies of an image mounted result in changes to both images if only one is modified
Date: Thu, 20 Jun 2013 11:34:05 +0100	[thread overview]
Message-ID: <20130620103404.GN11290@carfax.org.uk> (raw)
In-Reply-To: <kpul4f$ei7$1@ger.gmane.org>

[-- Attachment #1: Type: text/plain, Size: 2546 bytes --]

On Thu, Jun 20, 2013 at 10:22:07AM +0000, Gabriel de Perthuis wrote:
> On Thu, 20 Jun 2013 10:16:22 +0100, Hugo Mills wrote:
> > On Thu, Jun 20, 2013 at 10:47:53AM +0200, Clemens Eisserer wrote:
> >> Hi,
> >> 
> >> I've observed a rather strange behaviour while trying to mount two
> >> identical copies of the same image to different mount points.
> >> Each modification to one image is also performed in the second one.
> 
> >> touch m2/hello
> >> ls -la m1  //will now also include a file calles "hello"
> >> 
> >> Is this behaviour intentional and known or should I create a bug-report?
> > 
> >    It's known, and not desired behaviour. The problem is that you've
> > ended up with two filesystems with the same UUID, and the FS code gets
> > rather confused about that. The same problem exists with LVM snapshots
> > (or other block-device-layer copies).
> > 
> >    The solution is a combination of a tool to scan an image and change
> > the UUID (offline), and of some code in the kernel that detects when
> > it's being told about a duplicate image (rather than an additional
> > device in the same FS). Neither of these has been written yet, I'm
> > afraid.
> 
> To clarify, the loop devices are properly distinct, but the first
> device ends up mounted twice.
> 
> I've had a look at the vfs code, and it doesn't seem to be uuid-aware,
> which makes sense because the uuid is a property of the superblock and
> the fs structure doesn't expose it.  It's a Btrfs problem.

   Yes, it is. (I didn't intend, however obliquely, to imply that it
wasn't).

> Instead of redirecting to a different block device, Btrfs could and
> should refuse to mount an already-mounted superblock when the block
> device doesn't match, somewhere in or below btrfs_mount.  Registering
> extra, distinct superblocks for an already mounted raid is a different
> matter, but that isn't done through the mount syscall anyway.

   The problem here is that you could quite legitimately mount
/dev/sda (with UUID=AA1234) on, say, /mnt/fs-a, and /dev/sdb (with
UUID=AA1234) on /mnt/fs-b -- _provided_ that /dev/sda and /dev/sdb are
both part of the same filesystem. So you can't simply prevent mounting
based on the device that the mount's being done with.

   Hugo.

-- 
=== Hugo Mills: hugo@... carfax.org.uk | darksatanic.net | lug.org.uk ===
  PGP key: 65E74AC0 from wwwkeys.eu.pgp.net or http://www.carfax.org.uk
                   --- I know of three kinds: hot, ---                   
                cool,  and what-time-does-the-tune-start?                

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 828 bytes --]

  reply	other threads:[~2013-06-20 10:34 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-20  8:47 Two identical copies of an image mounted result in changes to both images if only one is modified Clemens Eisserer
2013-06-20  9:11 ` Fajar A. Nugraha
2013-06-20  9:16 ` Hugo Mills
2013-06-20 10:22   ` Gabriel de Perthuis
2013-06-20 10:34     ` Hugo Mills [this message]
2013-06-20 10:41       ` Gabriel de Perthuis
2013-06-20 10:56         ` Hugo Mills
2013-06-20 13:22           ` Kevin O'Kelley
2013-06-20 13:28             ` Hugo Mills
2013-06-20 13:29             ` Gabriel
2013-06-20 13:32           ` Hugo Mills

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130620103404.GN11290@carfax.org.uk \
    --to=hugo@carfax.org.uk \
    --cc=g2p.code@gmail.com \
    --cc=linux-btrfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).