linux-btrfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Liu Bo <bo.li.liu@oracle.com>
To: Josef Bacik <jbacik@fusionio.com>
Cc: linux-btrfs@vger.kernel.org
Subject: Re: [PATCH 4/4] Btrfs-progs: exhance btrfs-image to restore image onto multiple disks
Date: Thu, 20 Jun 2013 22:40:15 +0800	[thread overview]
Message-ID: <20130620144014.GA23986@localhost.localdomain> (raw)
In-Reply-To: <20130620123919.GB4288@localhost.localdomain>

On Thu, Jun 20, 2013 at 08:39:19AM -0400, Josef Bacik wrote:
> On Thu, Jun 20, 2013 at 08:24:32AM -0400, Josef Bacik wrote:
> > On Thu, Jun 20, 2013 at 08:05:30PM +0800, Liu Bo wrote:
> > > This adds a 'btrfs-image -m' option, which let us restore an image that
> > > is built from a btrfs of multiple disks onto several disks altogether.
> > > 
> > > This aims to address the following case,
> > > $ mkfs.btrfs -m raid0 sda sdb
> > > $ btrfs-image sda image.file
> > > $ btrfs-image -r image.file sdc
> > > ---------
> > > so we can only restore metadata onto sdc, and another thing is we can
> > > only mount sdc with degraded mode as we don't provide informations of
> > > another disk.  And, it's built as RAID0 and we have only one disk,
> > > so after mount sdc we'll get into readonly mode.
> > > 
> > 
> > Um that shouldn't be happening, the restore will mask out the RAID parts of the
> > chunk tree and it should work just fine.  Are you using the most recent version
> > of btrfs-image?  If this is happening it's a bug and we need to fix it, but I've
> > restored several file systems from users with raid0/10 file systems onto a
> > single disk and it's worked just fine.  Thanks,
> > 
> 
> Well apparently I've been hallucinating because it definitely doesn't work.  I'd
> rather fix the device tree so it only restores onto one disk, since the raid
> level shouldn't matter and it does in fact get masked out.  So the only thing
> left would be to fix the device tree so the only device it knows about is the
> device we're restoring to.  Thanks,

I just check the latest progs code, in
commit ef2a8889ef813ba77061f6a92f4954d047a78932
Btrfs-progs: make image restore with the original device offsets,
we suffer from an huge pain and take a great amount of efforts to map
logical offset to physical offset.

But with this patch, we'll build the same whole logical-physical mapping
on the disks we're restoring to with what it is on the disks that
generate the image file, so we can get rid of those pain causing by
mapping issues.

thanks,
liubo

  parent reply	other threads:[~2013-06-20 14:40 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-20 12:05 [PATCH 0/4] multiple disks restore support of btrfs-image Liu Bo
2013-06-20 12:05 ` [PATCH 1/4] Btrfs-progs: fix misuse of skinny metadata in btrfs-image Liu Bo
2013-06-20 12:05 ` [PATCH 2/4] Btrfs-progs: skip open devices which is missing Liu Bo
2013-06-20 12:05 ` [PATCH 3/4] Btrfs-progs: delete fs_devices itself from fs_uuid list before freeing Liu Bo
2013-06-20 12:05 ` [PATCH 4/4] Btrfs-progs: exhance btrfs-image to restore image onto multiple disks Liu Bo
2013-06-20 12:24   ` Josef Bacik
2013-06-20 12:39     ` Josef Bacik
2013-06-20 13:39       ` Liu Bo
2013-06-20 14:40       ` Liu Bo [this message]
2013-06-20 12:47     ` Chris Mason
2013-06-21  1:10   ` Chris Mason
2013-06-21  1:12     ` Liu Bo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130620144014.GA23986@localhost.localdomain \
    --to=bo.li.liu@oracle.com \
    --cc=jbacik@fusionio.com \
    --cc=linux-btrfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).