From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dkim2.fusionio.com ([66.114.96.54]:50335 "EHLO dkim2.fusionio.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757878Ab3FUAmS convert rfc822-to-8bit (ORCPT ); Thu, 20 Jun 2013 20:42:18 -0400 Received: from mx2.fusionio.com (unknown [10.101.1.160]) by dkim2.fusionio.com (Postfix) with ESMTP id 59EA79A0017 for ; Thu, 20 Jun 2013 18:42:18 -0600 (MDT) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 To: Sage Weil From: Chris Mason In-Reply-To: CC: Josef Bacik , "linux-btrfs@vger.kernel.org" References: <20130618163706.GC19183@localhost.localdomain> <20130618165952.9494.8953@localhost.localdomain> Message-ID: <20130621004216.4477.93556@localhost.localdomain> Subject: Re: hang on 3.9, 3.10-rc5 Date: Thu, 20 Jun 2013 20:42:16 -0400 Sender: linux-btrfs-owner@vger.kernel.org List-ID: Quoting Sage Weil (2013-06-20 17:56:19) > On Wed, 19 Jun 2013, Sage Weil wrote: > > Hi Chris, > > > > On Tue, 18 Jun 2013, Chris Mason wrote: > > > [...] > > > Very long way of saying I think we're one release_path short. Sage, I > > > haven't tested this at all yet, I was hoping to trigger it first. > > > > > > diff --git a/fs/btrfs/tree-log.c b/fs/btrfs/tree-log.c > > > index c276ac9..c1954b3 100644 > > > --- a/fs/btrfs/tree-log.c > > > +++ b/fs/btrfs/tree-log.c > > > @@ -3730,6 +3730,7 @@ next_slot: > > > log_extents: > > > if (fast_search) { > > > btrfs_release_path(dst_path); > > > + btrfs_release_path(path); > > > ret = btrfs_log_changed_extents(trans, root, inode, dst_path); > > > if (ret) { > > > err = ret; > > > > This seems to be doing the trick. I'll keep testing overnight, but so far > > so good! > > ...and it's still holding up well in QA. Awesome, thanks for getting the traces for us. Looks like this one has been around since v3.7, so I'm not going to try and sneak it into the 3.10 final. I'll have it in the next merge window and for stable. -chris