From: Josef Bacik <jbacik@fusionio.com>
To: Eric Sandeen <sandeen@redhat.com>
Cc: Josef Bacik <jbacik@fusionio.com>, <linux-btrfs@vger.kernel.org>
Subject: Re: [PATCH] xfstests: make fs for 274 larger
Date: Mon, 24 Jun 2013 09:33:23 -0400 [thread overview]
Message-ID: <20130624133323.GF4288@localhost.localdomain> (raw)
In-Reply-To: <51C4CB72.9080705@redhat.com>
On Fri, Jun 21, 2013 at 04:53:54PM -0500, Eric Sandeen wrote:
> On 6/21/13 3:30 PM, Josef Bacik wrote:
> > Btrfs will default to mixed block groups for 1 gigabyte file systems and
> > smaller, which means data and metadata share the same area. This makes
> > generic/274 fail for us because we cannot reserve enough metadata space to do
> > our writes. Bumping the scratch fs up to 2 gigabytes allows us to do our normal
> > metadata/data seperation and allows us to pass this test. Thanks,
>
> It'd be nice if we could force btrfs into the other mode just for this
> test, but it's probably harmless to just make everyone else bigger.
> Makes the test take longer though, another gig to write.
>
> Did you test other filesystems w/ the change?
>
> Seems like a reasonable & expedient solution though, so:
>
> Reviewed-by: Eric Sandeen <sandeen@redhat.com>
Yeah I tested xfs and ext4 and they worked out right, it takes a little longer
but its like 10-15 seconds so not too big of a deal. I had thought of making
this test force btrfs to do non-mixed but I didn't want to wire all that up when
we could just jack the size up. Thanks,
Josef
prev parent reply other threads:[~2013-06-24 13:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-21 20:30 [PATCH] xfstests: make fs for 274 larger Josef Bacik
2013-06-21 21:53 ` Eric Sandeen
2013-06-24 13:33 ` Josef Bacik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130624133323.GF4288@localhost.localdomain \
--to=jbacik@fusionio.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=sandeen@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).