From: Josef Bacik <jbacik@fusionio.com>
To: Zach Brown <zab@redhat.com>
Cc: Josef Bacik <jbacik@fusionio.com>, <xfs@oss.sgi.com>,
<linux-btrfs@vger.kernel.org>, Eric Sandeen <sandeen@redhat.com>
Subject: Re: [PATCH] xfstests: check if the scratch dev pool is mounted in _require_scratch
Date: Wed, 26 Jun 2013 15:34:46 -0400 [thread overview]
Message-ID: <20130626193446.GO4288@localhost.localdomain> (raw)
In-Reply-To: <20130626191804.GA20692@lenny.home.zabbo.net>
On Wed, Jun 26, 2013 at 12:18:04PM -0700, Zach Brown wrote:
> > $SCRATCH_DEV, so anybody who wants to just use the scratch mnt with the scratch
> > dev will fail to work because we never unmount the scratch mount.
>
> Yeah, this is annoying.
>
> > Fix this by
> > checking to see if the scratch dev pool is mounted at scratch mnt and unmount it
> > so we can run our test. This fixes the issue I was seeing by running
>
> But this fix seems bonkers. Can we have _scratch_unmount unmount the
> mountpoint instead of the device? That's what Eric suggested when I
> whined about this a while ago.
>
Well actually we probably need both, since we need callers of _scratch_umount to
actually work. But my patch is slightly wrong, I need to be making sure the
device is actually mounted at scratch mnt before I unmount it, otherwise error
out. Thanks,
Josef
prev parent reply other threads:[~2013-06-26 19:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-26 15:49 [PATCH] xfstests: check if the scratch dev pool is mounted in _require_scratch Josef Bacik
2013-06-26 19:18 ` Zach Brown
2013-06-26 19:34 ` Josef Bacik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130626193446.GO4288@localhost.localdomain \
--to=jbacik@fusionio.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=sandeen@redhat.com \
--cc=xfs@oss.sgi.com \
--cc=zab@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).