From: Chris Mason <chris.mason@fusionio.com>
To: Miao Xie <miaox@cn.fujitsu.com>, <linux-btrfs@vger.kernel.org>
Subject: Re: [PATCH 2/5] Btrfs: add branch prediction hints in the read page end IO function
Date: Thu, 11 Jul 2013 10:31:22 -0400 [thread overview]
Message-ID: <20130711143122.12026.78808@localhost.localdomain> (raw)
In-Reply-To: <1373520339-13870-2-git-send-email-miaox@cn.fujitsu.com>
Do you have benchmark numbers for how much these help? I hesitate to
bring in the likely/unlikely unless we can see it on the benchmarks.
(The patch does look fine though)
-chris
next prev parent reply other threads:[~2013-07-11 14:31 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-11 5:25 [PATCH 1/5] Btrfs: remove unnecessary argument of bio_readpage_error() Miao Xie
2013-07-11 5:25 ` [PATCH 2/5] Btrfs: add branch prediction hints in the read page end IO function Miao Xie
2013-07-11 14:31 ` Chris Mason [this message]
2013-07-12 22:19 ` David Sterba
2013-07-11 5:25 ` [PATCH 3/5] Btrfs: don't cache the csum value into the extent state tree Miao Xie
2013-07-11 14:29 ` Chris Mason
2013-07-11 5:25 ` [PATCH 4/5] Btrfs: batch the extent state operation in the end io handle of the read page Miao Xie
2013-07-11 18:56 ` Josef Bacik
2013-07-11 8:05 ` [PATCH 1/5] Btrfs: remove unnecessary argument of bio_readpage_error() Miao Xie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130711143122.12026.78808@localhost.localdomain \
--to=chris.mason@fusionio.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=miaox@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).