From: David Sterba <dsterba@suse.cz>
To: Josef Bacik <jbacik@fusionio.com>
Cc: linux-btrfs@vger.kernel.org
Subject: Re: [PATCH] Btrfs: don't bug_on when we fail when cleaning up transactions
Date: Thu, 1 Aug 2013 19:50:23 +0200 [thread overview]
Message-ID: <20130801175023.GA24343@twin.jikos.cz> (raw)
In-Reply-To: <1375280963-2043-1-git-send-email-jbacik@fusionio.com>
On Wed, Jul 31, 2013 at 10:29:23AM -0400, Josef Bacik wrote:
> There is no reason for this sort of jackassery. Thanks,
>
> Signed-off-by: Josef Bacik <jbacik@fusionio.com>
> ---
> fs/btrfs/transaction.c | 3 +--
> 1 files changed, 1 insertions(+), 2 deletions(-)
>
> diff --git a/fs/btrfs/transaction.c b/fs/btrfs/transaction.c
> index 18f7e71..ea8d522 100644
> --- a/fs/btrfs/transaction.c
> +++ b/fs/btrfs/transaction.c
> @@ -1942,6 +1942,5 @@ int btrfs_clean_one_deleted_snapshot(struct btrfs_root *root)
> * If we encounter a transaction abort during snapshot cleaning, we
> * don't want to crash here
> */
> - BUG_ON(ret < 0 && ret != -EAGAIN && ret != -EROFS);
> - return 1;
> + return (ret < 0) ? 0 : 1;
The reason was to let known harmless error codes pass and catch the
unexpected ones, but the whitelist was incomplete and I guess you've seen
something like ENOMEM or EIO. As the cleaning process is restartable I'm
ok with removing the bugon.
Reviewed-by: David Sterba <dsterba@suse.cz>
prev parent reply other threads:[~2013-08-01 17:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-31 14:29 [PATCH] Btrfs: don't bug_on when we fail when cleaning up transactions Josef Bacik
2013-08-01 17:50 ` David Sterba [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130801175023.GA24343@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=jbacik@fusionio.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).