From: Chris Mason <chris.mason@fusionio.com>
To: Sage Weil <sage@inktank.com>
Cc: Josef Bacik <jbacik@fusionio.com>,
"linux-btrfs@vger.kernel.org" <linux-btrfs@vger.kernel.org>
Subject: Re: hang on 3.9, 3.10-rc5
Date: Fri, 9 Aug 2013 14:08:52 -0400 [thread overview]
Message-ID: <20130809180852.17880.6919@localhost.localdomain> (raw)
In-Reply-To: <alpine.DEB.2.00.1308091101480.14125@cobra.newdream.net>
Quoting Sage Weil (2013-08-09 14:04:15)
> Hi Chris,
>
> On Thu, 20 Jun 2013, Chris Mason wrote:
> > Quoting Sage Weil (2013-06-20 17:56:19)
> > > On Wed, 19 Jun 2013, Sage Weil wrote:
> > > > Hi Chris,
> > > >
> > > > On Tue, 18 Jun 2013, Chris Mason wrote:
> > > > > [...]
> > > > > Very long way of saying I think we're one release_path short. Sage, I
> > > > > haven't tested this at all yet, I was hoping to trigger it first.
> > > > >
> > > > > diff --git a/fs/btrfs/tree-log.c b/fs/btrfs/tree-log.c
> > > > > index c276ac9..c1954b3 100644
> > > > > --- a/fs/btrfs/tree-log.c
> > > > > +++ b/fs/btrfs/tree-log.c
> > > > > @@ -3730,6 +3730,7 @@ next_slot:
> > > > > log_extents:
> > > > > if (fast_search) {
> > > > > btrfs_release_path(dst_path);
> > > > > + btrfs_release_path(path);
> > > > > ret = btrfs_log_changed_extents(trans, root, inode, dst_path);
> > > > > if (ret) {
> > > > > err = ret;
> > > >
> > > > This seems to be doing the trick. I'll keep testing overnight, but so far
> > > > so good!
> > >
> > > ...and it's still holding up well in QA.
> >
> > Awesome, thanks for getting the traces for us. Looks like this one has
> > been around since v3.7, so I'm not going to try and sneak it into the
> > 3.10 final. I'll have it in the next merge window and for stable.
>
> I was just pulling in the current -rc for testing and realized that this
> isn't upstream yet. Was this missed? Sorry I didn't check earlier.
Ack, thanks Sage. It'll go into the next pull (cc stable)
-chris
next prev parent reply other threads:[~2013-08-09 18:08 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-11 15:43 hang on 3.9, 3.10-rc5 Sage Weil
2013-06-11 16:21 ` Chris Mason
[not found] ` <alpine.DEB.2.00.1306121317300.27596@cobra.newdream.net>
2013-06-18 15:56 ` Sage Weil
2013-06-18 16:36 ` Chris Mason
2013-06-18 16:37 ` Josef Bacik
2013-06-18 16:59 ` Chris Mason
2013-06-20 3:44 ` Sage Weil
2013-06-20 21:56 ` Sage Weil
2013-06-21 0:42 ` Chris Mason
2013-06-21 1:00 ` Sage Weil
2013-06-21 1:04 ` Chris Mason
2013-06-21 1:09 ` Sage Weil
2013-08-09 18:04 ` Sage Weil
2013-08-09 18:08 ` Chris Mason [this message]
2013-06-18 17:19 ` Jon Nelson
2013-06-21 1:11 ` Chris Mason
2013-06-21 1:46 ` Jon Nelson
2013-06-21 5:40 ` Chris Murphy
2013-06-21 6:42 ` Clemens Eisserer
2013-06-25 15:52 ` Liu Bo
2013-06-21 11:30 ` Chris Mason
2013-06-21 13:14 ` Jon Nelson
2013-06-21 14:54 ` Johannes Hirte
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130809180852.17880.6919@localhost.localdomain \
--to=chris.mason@fusionio.com \
--cc=jbacik@fusionio.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=sage@inktank.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).