From: Josef Bacik <jbacik@fusionio.com>
To: Zach Brown <zab@redhat.com>
Cc: <linux-btrfs@vger.kernel.org>
Subject: Re: [PATCH 2/2] btrfs: don't double brelse on device rm
Date: Fri, 9 Aug 2013 17:05:00 -0400 [thread overview]
Message-ID: <20130809210500.GB861@localhost.localdomain> (raw)
In-Reply-To: <1376080634-1714-2-git-send-email-zab@redhat.com>
On Fri, Aug 09, 2013 at 01:37:14PM -0700, Zach Brown wrote:
> Device removal currently causes bdev removal to try to double free a bh
> in the bdev:
>
> [ 55.714833] WARNING: at fs/buffer.c:1160 __brelse+0x36/0x40()
> [ 55.714833] VFS: brelse: Trying to free free buffer
>
> Commit 7e3d9ebb1 added a double release of the bh for a device being
> removed when all the supers don't fit in the device. In that case it
> releases the bh assuming that it's going to read a new one, finds that
> it won't read, and goes to a label that releases the bh again.
>
> All it needed to do was only brelse() right before overwriting the
> current bh with __bread().
I've dropped this patch so we don't need this anymore. Thanks,
Josef
prev parent reply other threads:[~2013-08-09 21:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-09 20:37 [PATCH 1/2] btrfs: brelse in error path in open_ctree Zach Brown
2013-08-09 20:37 ` [PATCH 2/2] btrfs: don't double brelse on device rm Zach Brown
2013-08-09 21:05 ` Josef Bacik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130809210500.GB861@localhost.localdomain \
--to=jbacik@fusionio.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=zab@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).