Re: [PATCH v2] Btrfs-progs: add dedup subcommand

[Liu Bo <bo.li.liu@oracle.com>]

On Fri, Aug 09, 2013 at 02:51:35PM +0200, David Sterba wrote:
> On Thu, Aug 08, 2013 at 04:35:46PM +0800, Liu Bo wrote:
> > This aims to add deduplication subcommand, 'btrfs dedup command <path>',
> > ie. register/unregister'.
> 
> I'm not sure that calling it register/unregister is the right thing, IMO
> it's more enable/disable as you write in the documentation under each
> respective command.
> 

Both of them are easy to be understood, but let's keep it consistent
with the docs as you suggest :)

> Please post a list of the other commands if there are any, and the
> expected usage.
> 

So far only these two commands are needed, thanks for reviewing this.

-liubo

> thanks,
> david
> 
> > +\fBbtrfs dedup register\fP \fI<path>\fP
> > +Enable data deduplication support for a filesystem.
>    ^^^^^
> 
> > +.TP
> > +
> > +\fBbtrfs dedup unregister\fP \fI<path>\fP
> > +Disable data deduplication support for a filesystem.
>    ^^^^^^^