From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from bombadil.infradead.org ([198.137.202.9]:35244 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756105Ab3HLLr5 (ORCPT ); Mon, 12 Aug 2013 07:47:57 -0400 Date: Mon, 12 Aug 2013 04:47:52 -0700 From: Christoph Hellwig To: Josef Bacik Cc: Christoph Hellwig , Mark Fasheh , viro@ZenIV.linux.org.uk, linux-fsdevel@vger.kernel.org, linux-btrfs@vger.kernel.org, Chris Mason , Andrew Vagin Subject: Re: [PATCH][RESEND] vfs: allow /proc/PID/maps to get device from stat Message-ID: <20130812114752.GA2390@infradead.org> References: <20130807195718.GC31381@wotan.suse.de> <20130807201826.GA23804@infradead.org> <20130807205146.GE2397@localhost.localdomain> <20130808121349.GC5180@infradead.org> <20130808130207.GA16712@localhost.localdomain> <20130808134805.GB24181@infradead.org> <20130808154454.GF16712@localhost.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <20130808154454.GF16712@localhost.localdomain> Sender: linux-btrfs-owner@vger.kernel.org List-ID: On Thu, Aug 08, 2013 at 11:44:54AM -0400, Josef Bacik wrote: > On Thu, Aug 08, 2013 at 06:48:05AM -0700, Christoph Hellwig wrote: > > On Thu, Aug 08, 2013 at 09:02:07AM -0400, Josef Bacik wrote: > > > This won't work, try having 10000 subvolumes with dirty inodes and do sync then > > > go skiing, you'll have time :). Thanks, > > > > Why would the dirty inodes make any difference? If you share the bdi > > between the subvolumes the sync workflow should be exactly the same > > still. > > > > If we could dis-entangle vfsmounts from sb's and have it so you could have > multiple vfsmounts with just one sb that would solve at least the in-kernel > confusion, but I think we still have the userspace confusion. Thanks, I think it would mostly solve userspace confusion, as userspace only sees mounts and the device names. But please fix this up properly instead of propagating the effects of the nasty btrfs hack that should never have been merged in that form further up the stack.