From: Josef Bacik <jbacik@fusionio.com>
To: Duncan <1i5t5.duncan@cox.net>
Cc: <linux-btrfs@vger.kernel.org>
Subject: Re: [PATCH] Btrfs: don't allow a subvol to be deleted if it is the default subovl
Date: Tue, 13 Aug 2013 10:14:08 -0400 [thread overview]
Message-ID: <20130813141408.GE2150@localhost.localdomain> (raw)
In-Reply-To: <pan$445b2$64e1e159$c2f6f85b$84d1e879@cox.net>
On Tue, Aug 13, 2013 at 04:54:32AM +0000, Duncan wrote:
> Josef Bacik posted on Mon, 12 Aug 2013 15:39:35 -0400 as excerpted:
>
> > Fix this by adding a check to see if our default subvol points to the
> > subvol we are trying to delete, and if it does not allowing it to
> > happen.
>
> Umm... not to be a grammar policeman, but...
>
> That last sub-sentence REALLY (!!) needs another comma:
>
> ... and if it does, not allowing it to happen.
>
> or
>
> ... and if it does not, allowing it to happen.
>
I'll fix it up in git, sorry English isn't my first language. Thanks,
Josef
prev parent reply other threads:[~2013-08-13 14:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-12 19:39 [PATCH] Btrfs: don't allow a subvol to be deleted if it is the default subovl Josef Bacik
2013-08-13 4:54 ` Duncan
2013-08-13 14:14 ` Josef Bacik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130813141408.GE2150@localhost.localdomain \
--to=jbacik@fusionio.com \
--cc=1i5t5.duncan@cox.net \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).