From: Josef Bacik <jbacik@fusionio.com>
To: Eric Sandeen <sandeen@sandeen.net>
Cc: Dave Chinner <david@fromorbit.com>,
Jan Schmidt <list.xfs@jan-o-sch.net>,
"xfs@oss.sgi.com" <xfs@oss.sgi.com>,
"sbehrens@giantdisaster.de" <sbehrens@giantdisaster.de>,
"linux-btrfs@vger.kernel.org" <linux-btrfs@vger.kernel.org>
Subject: Re: [PATCH v3 1/2] xfstests: add fssum tool
Date: Tue, 13 Aug 2013 11:28:22 -0400 [thread overview]
Message-ID: <20130813152822.GG2150@localhost.localdomain> (raw)
In-Reply-To: <BB446B35-F3DA-462E-9E2C-9E4B780BC6B9@sandeen.net>
On Sun, Aug 11, 2013 at 09:54:41PM -0500, Eric Sandeen wrote:
> On Aug 11, 2013, at 8:15 PM, Dave Chinner <david@fromorbit.com> wrote:
>
> > On Thu, Aug 08, 2013 at 12:40:55PM -0500, Eric Sandeen wrote:
> >> On 8/8/13 3:17 AM, Jan Schmidt wrote:
> >>> SUBDIRS =
> >>>
> >>> LLDLIBS = $(LIBATTR) $(LIBHANDLE) $(LIBACL)
> >>>
> >>> +OPT_LDLIBS = -lssl -lcrypto
> >>
> >> Hm, new deps. I guess it's not a huge problem, these should always
> >> be available, right?
> >
> > Please, let's keep crypto out of xfstests if we can. That's just
> > going to add a nightmare of US export compliance garbage to any
> > distro that wants to package and ship this....
> >
> It's ssl that's (optionally) required for check summing I believe. But it's optional if done properly...
>
It doesn't build without -lcrypto for me, so either we have an external
dependancy (which I'm fine with), or we add it to xfstests (which is what you
wanted). Does a config option alleviate your concerns? And I it's just linking
it in at build time, I don't think we have to work about export compliance as
long as we aren't shipping actual crytpo stuff right? Anybody who is going to
be running this stuff is going to have libssl installed, which installs
libcrypto (at least on my box) so I don't think it's a huge deal to have us
linking it. Thanks,
Josef
next prev parent reply other threads:[~2013-08-13 15:28 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-08 8:17 [PATCH v3 0/2] xfstest btrfs/316: test send / receive Jan Schmidt
2013-08-08 8:17 ` [PATCH v3 1/2] xfstests: add fssum tool Jan Schmidt
2013-08-08 17:40 ` Eric Sandeen
2013-08-12 1:15 ` Dave Chinner
2013-08-12 2:54 ` Eric Sandeen
2013-08-13 15:28 ` Josef Bacik [this message]
2013-08-13 16:28 ` Eric Sandeen
2013-08-08 8:17 ` [PATCH v3 2/2] xfstests btrfs/316: test send / receive Jan Schmidt
2013-08-08 17:45 ` Eric Sandeen
2013-08-08 17:34 ` [PATCH v3 0/2] xfstest " Eric Sandeen
2013-08-09 15:58 ` Eric Sandeen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130813152822.GG2150@localhost.localdomain \
--to=jbacik@fusionio.com \
--cc=david@fromorbit.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=list.xfs@jan-o-sch.net \
--cc=sandeen@sandeen.net \
--cc=sbehrens@giantdisaster.de \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).