From: David Sterba <dsterba@suse.cz>
To: Josef Bacik <jbacik@fusionio.com>
Cc: linux-btrfs@vger.kernel.org
Subject: Re: [PATCH] Btrfs: add support for asserts V2
Date: Fri, 30 Aug 2013 23:46:40 +0200 [thread overview]
Message-ID: <20130830214640.GS23113@twin.jikos.cz> (raw)
In-Reply-To: <1377799797-9738-1-git-send-email-jbacik@fusionio.com>
On Thu, Aug 29, 2013 at 02:09:57PM -0400, Josef Bacik wrote:
> +#define ASSERT(expr) \
> + (likely(expr) ? (void)0 : assfail(#expr, __FILE__, __LINE__))
> +#else
> +#define ASSERT(expr) ((void)0)
> +#endif
> +
> +#define btrfs_assert()
This is unused and without any ifdef-ed alternatives, should go away I
think.
> __printf(5, 6)
> void __btrfs_std_error(struct btrfs_fs_info *fs_info, const char *function,
> unsigned int line, int errno, const char *fmt, ...);
prev parent reply other threads:[~2013-08-30 21:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-29 18:09 [PATCH] Btrfs: add support for asserts V2 Josef Bacik
2013-08-30 21:46 ` David Sterba [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130830214640.GS23113@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=jbacik@fusionio.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).