linux-btrfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Sterba <dsterba@suse.cz>
To: Anand Jain <Anand.Jain@oracle.com>
Cc: dsterba@suse.cz, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH v2] btrfs-progs: mkfs should check for small vol well before
Date: Tue, 3 Sep 2013 19:53:01 +0200	[thread overview]
Message-ID: <20130903175301.GC32382@twin.jikos.cz> (raw)
In-Reply-To: <52217F51.4000706@oracle.com>

On Sat, Aug 31, 2013 at 01:29:53PM +0800, Anand Jain wrote:
>  Thanks for taking care of this David. Let me know if anywhere
>  needs more explanation.
>  I have been introducing series of device related changes in
>  btrfs-progs/mkfs which were/is essential bug fix. Fixes looks
>  complex since originally btrfs-progs/mkfs didn't create and
>  use much of helper functions in this area, now with these
>  fixes its much modular and better.

Yeah mkfs needs clean ups, thanks for doing that. I'm running btrfs/003
on top of various mkfs option combinations, so far it hasn't blown up at
mkfs time, the patches included are

btrfs-progs: mkfs should check for small vol well before
btrfs-progs: avoid write to the disk before sure to create fs

and excluded

btrfs-progs: mkfs.c overwrites fd without appropriate close
btrfs-progs: Fix: mkfs.c overwrites fd without appropriate close patch

david

      reply	other threads:[~2013-09-03 17:53 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-16 12:52 [PATCH] btrfs-progs: mkfs should check for small vol well before Anand Jain
2013-08-30  8:42 ` [PATCH] btrfs-progs: use btrfs error code for kernel errors Anand Jain
2013-08-30  8:50 ` [PATCH v2] btrfs-progs: mkfs should check for small vol well before Anand Jain
2013-08-30 23:22   ` David Sterba
2013-08-31  5:29     ` Anand Jain
2013-09-03 17:53       ` David Sterba [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130903175301.GC32382@twin.jikos.cz \
    --to=dsterba@suse.cz \
    --cc=Anand.Jain@oracle.com \
    --cc=linux-btrfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).