linux-btrfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Josef Bacik <jbacik@fusionio.com>
To: Eric Sandeen <sandeen@redhat.com>
Cc: "Тимофей Титовец" <nefelim4ag@gmail.com>, linux-btrfs@vger.kernel.org
Subject: Re: btrfs-convert won't convert ext* - No valid Btrfs found on /dev/sdb1
Date: Thu, 5 Sep 2013 14:44:53 -0400	[thread overview]
Message-ID: <20130905184453.GF15634@localhost.localdomain> (raw)
In-Reply-To: <5228A713.6060003@redhat.com>

On Thu, Sep 05, 2013 at 10:45:23AM -0500, Eric Sandeen wrote:
> On 9/5/13 9:43 AM, Тимофей Титовец wrote:
> > Hello guys, i try to convert ext4 volume, but btrfs-convert show me error:
> > "No valid Btrfs found on file
> > unable to open ctree
> > conversion aborted."
> > Ubuntu 13.04
> > Kernel: 3.11
> > btrfs-progs git version 0.20-git20130822~194aa4a13
> > 
> > way to reproduce error:
> > $ truncate -s 4G file
> > $ mkfs.ext4 file #say yes to create fs on non block device.
> > $ btrfs-convert file
> >  No valid Btrfs found on file
> >  unable to open ctree
> >  conversion aborted.
> 
> This was a regression around July 3; there was no regression test at
> the time.
> 
> [615f2867854c186a37cb2e2e5a2e13e9ed4ab0df] Btrfs-progs: cleanup similar code in open_ctree_* and close_ctree
> 
> broke it.
> 
> Patches were sent to the list to fix it on July 17,
> 
> https://patchwork.kernel.org/patch/2828820/
> 
> but they haven't been merged into the main repo.
> 
> I sent a regression test for it to the list on Aug 4, but nobody
> reviewed it, so it hasn't been merged into the test suite, either.
> 
> Winning all around!

Alright, alright I'll review it, Jesus.  ;),

Josef

  reply	other threads:[~2013-09-05 18:44 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-05 14:43 btrfs-convert won't convert ext* - No valid Btrfs found on /dev/sdb1 Тимофей Титовец
2013-09-05 14:54 ` Hugo Mills
2013-09-05 15:06   ` Roman Mamedov
2013-09-05 15:30     ` Hugo Mills
2013-09-05 15:34       ` Roman Mamedov
2013-09-05 15:44         ` Hugo Mills
2013-09-05 15:45 ` Eric Sandeen
2013-09-05 18:44   ` Josef Bacik [this message]
2013-10-11  7:52     ` Daniel
2013-10-11  8:00       ` Wang Shilong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130905184453.GF15634@localhost.localdomain \
    --to=jbacik@fusionio.com \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=nefelim4ag@gmail.com \
    --cc=sandeen@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).