From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from caramon.arm.linux.org.uk ([78.32.30.218]:54573 "EHLO caramon.arm.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755584Ab3IMMQD (ORCPT ); Fri, 13 Sep 2013 08:16:03 -0400 Date: Fri, 13 Sep 2013 13:15:29 +0100 From: Russell King To: Josh Boyer Cc: Geert Uytterhoeven , Chris Mason , Mark Fasheh , Linus Torvalds , linux-btrfs , "Linux-Kernel@Vger. Kernel. Org" , Linux-Arch Subject: Re: [GIT PULL] Btrfs Message-ID: <20130913121529.GA1437@flint.arm.linux.org.uk> References: <20130912153629.16487.88969@localhost.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: Sender: linux-btrfs-owner@vger.kernel.org List-ID: On Fri, Sep 13, 2013 at 07:53:21AM -0400, Josh Boyer wrote: > I'm not an ARM expert, so I don't know if ARM should use the > asm-generic implementations, or just use __get_user/__put_user in all > cases. I've CC'd rmk. Why do we have uaccess-unaligned.h ? Normally, these kinds of things are spawned by architectures which have problems with unaligned accesses, ARM being one of them, but afaik we've never need this. With the kernel-side trapping of unaligned accesses on older hardware, we've always dealt with the normal accessor faulting. >>From what I can tell in the git history, these unaligned put_user and get_user have existed all the way back to the dawn of git use. Can someone enlighten me why we have them? -- Russell King