From: David Sterba <dsterba@suse.cz>
To: Anand Jain <anand.jain@oracle.com>
Cc: dsterba@suse.cz, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH v2 2/2] btrfs-progs: use kernel for mounted and lblkid to scan disks
Date: Fri, 13 Sep 2013 17:56:46 +0200 [thread overview]
Message-ID: <20130913155646.GL6810@twin.jikos.cz> (raw)
In-Reply-To: <5232EDA6.6060902@oracle.com>
On Fri, Sep 13, 2013 at 06:49:10PM +0800, Anand Jain wrote:
> >I wonder if we should keep --all-devices as a last resort fallback eg.
>
> Any idea whats the real use of --all-devices option anyway
> I am unsure. Anyway will restore --all-devices so now.
That's when udev breaks or is not present on the system at all.
http://thread.gmane.org/gmane.comp.file-systems.btrfs/11336
It's hard to know if there are users or not, from the thread above there
is at least one.
A good practice is to leave some deprecation period before removing a
functionality, so we should rather add a warning that the option is
about to be removed -- because udev is everywhere and computers don't
break, right?
> >I see this warning and there are no mounted filesystems listed in the
> >output:
> >
> >$ ./btrfs fi show
> >ERROR: scan kernel failed, -1
>
> when does this happen ? I can't reproduce it.
Reproduced with today's linus tree (btrfs pull is there), progs contain the
patches in question:
blkid lists btrfs filesysems:
/dev/sda5
/dev/sda6
/dev/sda7
/dev/sda8
/dev/sda9
/dev/sda11
/dev/sda15
/dev/sdb
mounted filesystems:
/dev/sda5 /mnt/a1 btrfs rw,relatime,space_cache 0 0
/dev/sdb /mnt/test btrfs rw,relatime,space_cache 0 0
$ ./btrfs fi show
ERROR: scan kernel failed, -1
Label: none uuid: 7c7c948e-c8bc-40fb-88e3-19a3dd4fe6f9 (unmounted)
Total devices 2 FS bytes used 288.00KiB
devid 2 size 4.04GiB used 0.00 path /dev/sda15
*** Some devices missing
Label: none uuid: a7e96a20-eceb-4593-a836-a8657c66e24b (unmounted)
Total devices 2 FS bytes used 6.87GiB
devid 1 size 10.00GiB used 9.03GiB path /dev/sda11
devid 0 size 10.00GiB used 4.01GiB path /dev/sda9
sda6/7/8/9 belong to sda5 and are not listed here
next prev parent reply other threads:[~2013-09-13 15:56 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-30 8:35 [PATCH 0/2] v2, fi show, dev scan and lblkid Anand Jain
2013-08-30 8:35 ` [PATCH 1/2] btrfs-progs: v4, move out print in cmd_df to another function Anand Jain
2013-08-30 8:35 ` [PATCH 2/2] btrfs-progs: use kernel for mounted and lblkid to scan disks Anand Jain
2013-09-06 9:37 ` [PATCH 1/2 resend] btrfs-progs: v4, move out print in cmd_df to another function Anand Jain
2013-09-06 9:37 ` [PATCH v2 2/2] btrfs-progs: use kernel for mounted and lblkid to scan disks Anand Jain
2013-09-12 16:36 ` David Sterba
2013-09-13 10:49 ` Anand Jain
2013-09-13 15:56 ` David Sterba [this message]
2013-09-13 16:21 ` David Sterba
2013-09-12 15:42 ` [PATCH 1/2 resend] btrfs-progs: v4, move out print in cmd_df to another function David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130913155646.GL6810@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=anand.jain@oracle.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).